Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118251
MIME-Version: 1.0
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CABTDVhBTbYMRT0vXX9+kyZ5CEJifhbPO0DH47bU2fy6EZHcD7g@mail.gmail.com> <9dc8105d-a26e-18e7-a858-a6360e78b1a6@bastelstu.be>
In-Reply-To: <9dc8105d-a26e-18e7-a858-a6360e78b1a6@bastelstu.be>
Date: Tue, 12 Jul 2022 21:21:29 +0900
Message-ID: <CAMs36HfWYPrus55DJH3iAFdKvk93oA-DNgh_M6_apyU3uDQeUg@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000e5998105e39ab52f"
Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement
From: g-kudo@colopl.co.jp (Go Kudo)

--000000000000e5998105e39ab52f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B47=E6=9C=888=E6=97=A5(=E9=87=91) 1:44 Tim D=C3=BCsterhus <tim@b=
astelstu.be>:

> Hi
>
> On 7/7/22 17:52, Go Kudo wrote:
> > Implementation is now proceeding.
> > It includes fixes to some of the issues that were pointed out previousl=
y.
> >
> > https://github.com/php/php-src/pull/8094
> >
> > `Randomizer::arrayPickKeys()` is currently not implemented for now, sin=
ce
> > it is most likely to be rejected.
> > (Of course, we are ready to revert to the other items if they are also
> > rejected.)
> >
> > I want to see if it looks good to you.
>
> I've reviewed the current implementation of the engines with a specific
> focus on the tests.
>
> 1. I have verified the Xoshiro256** tests against a pure PHP
> implementation (which I verified against the C reference implementation
> [1]).
>
> 2. I have verified the Pcg64OneseqXslRr64 pcgoneseq128xslrr64_value.phpt
> test against the reference C implementation [2] with the attached
> pcg-verification.c.
>
> 3. I have verified the Mt19937 mt_value.phpt test against the C++
> standard library implementation [3] with the attached mt-verification.cc.
>
> The three engines do what they are supposed to do. I'm not qualified to
> review with regard to PHP Internals best practices. It would be good if
> someone with the necessary expertise could proceed with that part of the
> review.
>
> Best regards
> Tim D=C3=BCsterhus
>
> [1] https://prng.di.unimi.it/xoshiro256starstar.c
> [2] https://www.pcg-random.org/download.html#c-implementation
> [3]
> https://en.cppreference.com/w/cpp/numeric/random/mersenne_twister_engine


Hi Tim.

Sorry for the late reply. Thanks for the verification.

I changed the serialization format to hex string as you pointed out
earlier. You should now be able to validate your PHP implementation.

Regards,
Go Kudo

--000000000000e5998105e39ab52f--