Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118241
MIME-Version: 1.0
References: <CAH19jWhvuLBT3kZ-u1SPEgwEec=JfALuaiy+Lma9F8WAbqANWw@mail.gmail.com>
 <CAMrTa2E27EHQvtB=r0NvNRHH8-bjmexaQH3rsWAfKgO3ObiQtg@mail.gmail.com>
 <ee29c9e1-a163-e996-dc0d-f77031e7a75b@telia.com> <34112e9f-057f-1045-ffdb-99aee9df2353@gmail.com>
In-Reply-To: <34112e9f-057f-1045-ffdb-99aee9df2353@gmail.com>
Date: Sun, 10 Jul 2022 23:13:17 +0200
Message-ID: <CAF+90c9aj67i4TR7Rq=+Mn4k+9oeSF0yDG8aFH7WftBtE69c8g@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000070b70205e379e829"
Subject: Re: [PHP-DEV] [RFC] [VOTE] Constants in traits
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000070b70205e379e829
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 10, 2022 at 3:46 PM Rowan Tommins <rowan.collins@gmail.com>
wrote:

> On 10/07/2022 13:51, Bj=C3=B6rn Larsson via internals wrote:
> > I think it's quite unlikely to deprecate such a rather big feature and
> > from that perspective I think one should do it as good as possible.
> >
> > Even if one thinks that this is a bad feature not to be expanded, why
> > not try to make it work better? So, I hope this RFC passes!
>
>
> I agree.
>
> Having sat down and read through the RFC, it is extremely conservative
> in its scope, and presents a clear case that it will fix a source of
> bugs in things that people can already do, i.e. reference constants
> inside a trait definition.
>
> It seems very unlikely that this change will make people suddenly use
> traits in more "wrong" places, nor prevent any alternative horizontal
> reuse / composition aid features being added in future.
>

I tend to agree. While I strongly dislike traits (or at least our
implementation of them), they're here to stay and we should make them less
bad where we can. Adding support for constants in traits makes sense to me,
because it removes an arbitrary limitation and inconsistency, and removes
the need for people to work around this in ways that are much worse -- for
example, by having an implicit contract between the trait and the using
class, as shown in the RFC.

Regards,
Nikita

--00000000000070b70205e379e829--