Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118194
Message-ID: <897a7af9-685f-4e87-3331-d99e36521f2e@alec.pl>
Date: Tue, 5 Jul 2022 09:44:59 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <7d72b5c1-d19b-8734-57e0-f02c402b09c2@gmail.com>
 <CAEKnhAEUPn48mOEFPUfYCp23F_PjtwtEjOUY0V2vOwom6rPjwQ@mail.gmail.com>
 <64e73280-83aa-c60d-4c01-54a617c5468f@gmail.com>
 <CAEKnhAF21rdAARVMjXq44+rjLej9rEGNigr-iPXP4YWNKkTfmQ@mail.gmail.com>
 <CAPg3Xx+d1jkpCG_iV464hJWdC_UqEpns-F-Phtog4bA2DbJEJg@mail.gmail.com>
 <8fd7bed5-2392-dec2-27d4-f2055e7021f1@heigl.org>
In-Reply-To: <8fd7bed5-2392-dec2-27d4-f2055e7021f1@heigl.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Add json_encode indent parameter
From: alec@alec.pl (Aleksander Machniak)

On 05.07.2022 09:37, Andreas Heigl wrote:
> What I would have prefered is instead of a the new parameter $indent 
> having a numerical value to have a string value.
> 
> That would have allowed the following:
> 
>      json_encode($data, indent: "    ");
> 
> or
> 
>      json_encode($data, indent: "\t");
> 
> That would have made the tabs vs. spaces very easy and people can also 
> add whatever they want to set for one indentation. Think about setting 
> dots for making the spaces visible for some formatted output or whatever 
> else people might think of.
> 
> And setting the "indent" parameter would always implicitly set the flag 
> "JSON_PRETTY_PRINT" (as it doesn't make sense to not have that set).
> 
> The current way of just being able to set a number of spaces to indent 
> or to use a flag for tabs is a bit fiddly at best and does make adding 
> accessibility a second class citizen. Therefore I will vote against this 
> current implementation.


I voted No for the same reason.

-- 
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com