Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118192
MIME-Version: 1.0
References: <e506a378-2060-4cc1-98a6-3c9c7c0bd903@www.fastmail.com>
 <CADyq6sJ0mvA9i4qEzeJ2K6JRakQNaMZz-cFAh3YV_iT=v3s+iA@mail.gmail.com> <6128711.lOV4Wx5bFT@arnaud-t490>
In-Reply-To: <6128711.lOV4Wx5bFT@arnaud-t490>
Date: Tue, 5 Jul 2022 09:27:34 +0200
Message-ID: <CADyq6sKuuuMMSHZvKDNe0soht5rmN98WNS6Kb=DMVne8Khd5Cw@mail.gmail.com>
To: Arnaud Le Blanc <arnaud.lb@gmail.com>
Cc: Larry Garfield <larry@garfieldtech.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000005306c05e309caba"
Subject: Re: [PHP-DEV] [RFC][Vote] Auto-capture closures
From: ocramius@gmail.com (Marco Pivetta)

--00000000000005306c05e309caba
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 4 Jul 2022, 19:15 Arnaud Le Blanc, <arnaud.lb@gmail.com> wrote:

> > Important to note how `Zend/zend_compile.c` now depends on `Optimizer/`=
,
> > which is a potential design issue.
>
> The Optimizer was moved to `Zend/Optimizer` earlier so that in the long
> term
> it could be used by the compiler pipeline directly (rather than as part o=
f
> caching).
>

Thanks for clarifying!

>
> There are clear benefits in reusing the Optimizer here. Duplicating or
> reimplementing live variable analysis would increase maintenance cost,
> whereas
> by reusing the Optimizer's implementation we take profit of a fast and
> well
> tested implementation.
>
> Greets,
>


This is fine, but it creates a bidirectional dependency between components
where the dependency graph was previously (in theory) acyclic.

This will become "someone else's problem" =F0=9F=98=AC

--00000000000005306c05e309caba--