Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118190 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 95763 invoked from network); 5 Jul 2022 05:24:43 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 5 Jul 2022 05:24:43 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 06B61180381 for ; Tue, 5 Jul 2022 00:17:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_40, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 5 Jul 2022 00:17:25 -0700 (PDT) Received: by mail-pj1-f53.google.com with SMTP id o15so6837302pjh.1 for ; Tue, 05 Jul 2022 00:17:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WnPUWy/fE49DZvFO+4CRgsPRfXOx/iIS7N6AU/9xZrY=; b=IVtFplz10Yo/hHF0/cBFZPEupSy4ch9Z6r3kTKFbLdI/K7H4wNa9LZumOP3FkvW/KJ 25NO8xLZRZBY/XsI7cnAzXx2JO5sUR9qO5cgm8Bfwg2w1DBRsv3bHRF2QXHGhhWG0Nlb MFEel5w8h106inK5rc6HIdTGkS81mEz1hTxigI8a/sgQSFYm84pFjahJlhNXroBmgFTW yJLAqSqCgrsBmfJR0TeT3rQs7ntRGLnQi217mvODIzuN1aV4gmzsqr0kval1oL+NqgHG wpV6Go6kGzZF9MzhcZsItaH4ROrrkUtBsMnxLa+VLZw31gkwUAz+8SE6WFTpfqiHr87L P2pw== X-Gm-Message-State: AJIora9P0BG8nXJUEviU4Rjlhqwb2lUGJalWdLyWv8NtiFiBpICpE/PC JWZg90CGAVm6H+m6LA+SzgR+bQyTV6oMdqWx4gjeLYGsgAuXiA== X-Google-Smtp-Source: AGRyM1ugvBKWtSTraeNC1rMVjSn1zphdawRLAWkfrn0rNARLTxM3xJ1oFVUSAVnKGBikgC5i0wVZ4h2NyqbKpH6UD9s= X-Received: by 2002:a17:902:76c4:b0:16a:deb:c0ae with SMTP id j4-20020a17090276c400b0016a0debc0aemr41115207plt.22.1657005444955; Tue, 05 Jul 2022 00:17:24 -0700 (PDT) MIME-Version: 1.0 References: <3d8fc412-0cd5-715e-e86a-07b8c77dce87@alec.pl> In-Reply-To: <3d8fc412-0cd5-715e-e86a-07b8c77dce87@alec.pl> Date: Tue, 5 Jul 2022 03:17:13 -0400 Message-ID: To: Aleksander Machniak Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary="000000000000f019cb05e309a446" Subject: Re: [PHP-DEV] [RFC][Vote] New Curl URL API From: pierrick@php.net (Pierrick Charron) --000000000000f019cb05e309a446 Content-Type: text/plain; charset="UTF-8" Sorry about that const CURLUPART_USER = UNKNOWN; // what UNKNOWN? > UNKNOWN means that the value here is not relevant for the user to know. But for clarification, the values of those constants will be the exact same values of the same constants in libcurl. "All errors of libcurl will become CurlUrlException." > You have a small section about CurlUrlException, but if you have for example a bad port when you set it a CurlUrlException will be thrown, with a CurlUrlException::BAD_PORT_NUMBER error code and a more user friendly message. > > "Setting a part to a null value will effectively remove that part's > contents", but the $content argument is of type string not ?string. > My bad. I took the liberty of fixing this even if the voting was open since I don't think it will change the actual 3 voters' vote. Pierrick --000000000000f019cb05e309a446--