Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118178 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 25388 invoked from network); 4 Jul 2022 08:19:01 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 4 Jul 2022 08:19:01 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A695A1804F8 for ; Mon, 4 Jul 2022 03:11:30 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_20, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 4 Jul 2022 03:11:30 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id c13so11034576eds.10 for ; Mon, 04 Jul 2022 03:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5A65Yaf0YA7/SXrjxWTQaAgyEonR3/ciWbheX6vDLAM=; b=ciTLQ7stGgM4WD5IeVpyVnIQ/KjlZkf3YhYUg8jkq3KCSyycr7y4pHRG13lSY++n5K shbaxEwDAOeN7CaAxz5dAecSdNZaPeXhjVZZT0J3zgB9dGLeykYMBy8aGrEVCQshyy3W JHq+Xu6bVbXqKcfJXoq2mYtjZmDVDsODT4E1CMjcbb0jWdhBSA7TTT71DT9eSADbPwUp bpYJr9hy59rOYoC0vNsO0YrB1/SHA82Az53QNaFzC4wkOSsN8vO0X10yS83iqBkxVpnQ GfEhbToHrp5SjKKn5uGU/uH2sc6qmSNoOv7d3FUc0ensizcVqNmgvUfCIxwh7FELFztJ 6ZLw== X-Gm-Message-State: AJIora8+tt7N7pV9WzFYQWAxOnPgh1j0t92DTHmLw5a1ltiYxDowjwFh qP8+a0RGnL8laZN5BY3GqN5aX6cgYIhNuAwa0vg= X-Google-Smtp-Source: AGRyM1uuEICXm35aWq2S9vBbC6ZGx6LzpgOKAknnlOU6+w5r4ZDzebTFcMQLAuJoNbYi9qce9o0RAANDZvwwVh5VJgs= X-Received: by 2002:a05:6402:1cc8:b0:437:a61a:5713 with SMTP id ds8-20020a0564021cc800b00437a61a5713mr38029214edb.340.1656929488703; Mon, 04 Jul 2022 03:11:28 -0700 (PDT) MIME-Version: 1.0 References: <7d72b5c1-d19b-8734-57e0-f02c402b09c2@gmail.com> <64e73280-83aa-c60d-4c01-54a617c5468f@gmail.com> In-Reply-To: <64e73280-83aa-c60d-4c01-54a617c5468f@gmail.com> Date: Mon, 4 Jul 2022 11:11:17 +0100 Message-ID: To: Timon de Groot Cc: PHP internals Content-Type: multipart/alternative; boundary="00000000000097939005e2f7f5dc" Subject: Re: [PHP-DEV] [RFC] Add json_encode indent parameter From: bukka@php.net (Jakub Zelenka) --00000000000097939005e2f7f5dc Content-Type: text/plain; charset="UTF-8" On Mon, Jul 4, 2022 at 8:38 AM Timon de Groot wrote: > Hi internals, > > If the rest also thinks the RFC is good to go, I suggest we start a vote > coming week. > As this is my first RFC, I'm not so sure how this typically gets kicked > off, so I'd like to know what I need to do! > You just need to change status in RFC to Voting and in voting section set the date range and add doodle poll - you can basically copy it from one of the open RFC's (see for example code in https://wiki.php.net/rfc/fetch_property_in_const_expressions ). Then you just need to send email to internals with subject prefixed with [RFC][VOTE] or similar. As noted you need to do it today or latest tomorrow. Feel free to let me know if you are too busy or something is not clear. I would recommend not to do any last time changes as in such case you should probably give an extra time for dicusion which means it won't make the feature freeze and will have to wait for another year. In my opinion it is good as it is. The tabs can be later added as an extra flag. If the flag is set, we could just change default value for indent to 1 and use tabs but it would be still possible for users to set indent size if they wish. I think that's something that makes most sense to me and doesn't impact the current RFC in any way. Regards Jakub --00000000000097939005e2f7f5dc--