Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118168
Message-ID: <b44a5eb6-6d7e-3674-2780-d36ab4fd197e@gmail.com>
Date: Mon, 4 Jul 2022 09:41:32 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
To: PHP internals <internals@lists.php.net>
References: <7d72b5c1-d19b-8734-57e0-f02c402b09c2@gmail.com>
 <CAEKnhAEUPn48mOEFPUfYCp23F_PjtwtEjOUY0V2vOwom6rPjwQ@mail.gmail.com>
 <DM5PR04MB0251ED33B3751530951716D2C1BE9@DM5PR04MB0251.namprd04.prod.outlook.com>
In-Reply-To: <DM5PR04MB0251ED33B3751530951716D2C1BE9@DM5PR04MB0251.namprd04.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Add json_encode indent parameter
From: tdegroot96@gmail.com (Timon de Groot)

As a flag can't really hurt, I'm thinking of going with option B before 
starting the vote.
Also agree with ignoring the indent parameter, as a tab character is 
less dependent on how much it is repeated.

Kind regards,

Timon

On 04-07-2022 03:22, Kevin Israel wrote:
> On 7/3/22 18:01, Jakub Zelenka wrote:
>>   I think we can put this RFC to the vote. If the author is to busy I 
>> would
>> like to start voting later this week. It would be a pity not to make 
>> it to
>> feature freeze as it is quite straight forward and the implementation 
>> seems
>> good as well so I guess we don't need to wait extra year. :)
>>
>> Cheers
>>
>> Jakub
>>
> This RFC really should have included an option to use tabs instead of 
> spaces, which is, IMO, even more important than having a parameter for 
> the number of spaces. This could take the form of either
> 
> (a) a magic indent value such as -1, or
> 
> (b) a new flag (suggested name: JSON_INDENT_USING_TABS).
> 
> There should be no need to support indenting using multiple tabs per 
> level; for option (b), the value of the indent parameter should be ignored.
> 
> An indent-using-tabs flag would even be useful for generating two-space 
> indented JSON, should the proposed indent parameter be rejected. The 
> reason is that tabs cannot occur within JSON string representations, so 
> any other indent string is a simple str_replace() away. In contrast, 
> replacing the current four-space indent with anything else is more 
> complicated to do efficiently[1].
> 
> [1]: 
> https://github.com/wikimedia/mediawiki/blob/210a34369ac8f0ba74b497d0b2298ca7e5a0bffb/includes/json/FormatJson.php#L113-L117 
> 
>