Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118165
Message-ID:
 <DM5PR04MB0251ED33B3751530951716D2C1BE9@DM5PR04MB0251.namprd04.prod.outlook.com>
Date: Sun, 3 Jul 2022 21:22:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-US
To: Jakub Zelenka <bukka@php.net>, Timon de Groot <tdegroot96@gmail.com>
Cc: PHP internals <internals@lists.php.net>
References: <7d72b5c1-d19b-8734-57e0-f02c402b09c2@gmail.com>
 <CAEKnhAEUPn48mOEFPUfYCp23F_PjtwtEjOUY0V2vOwom6rPjwQ@mail.gmail.com>
In-Reply-To: <CAEKnhAEUPn48mOEFPUfYCp23F_PjtwtEjOUY0V2vOwom6rPjwQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 42ef7061-b2f9-42d6-118c-08da5d5bb762
X-MS-TrafficTypeDiagnostic: BYAPR04MB4056:EE_
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dv+x2eKIQWmU5tWF0so8Q4vR2RDThDJxvJGjqeW/LZYHvd3E1I8C8sz38Oj0iDlRYgUMOsUIpPimdi8SxUpCJx2eSt48/Ry1Xp2yzvypEFxZIi/4YhD3N/EcrG7e9O2x9RTvMMa7IXAQ2wy+Xbpr7AOylXrnPJA9EKeJFG3HzWZ8nZIQEy0kQLSoZAuKJhXypY8yDc5CdPl9J1Iu2K2RzTgb3NwMkiRJjce9Uccn4GwrcTS5z7Re1pw/b/ybSR/ZB3Vj5UX5toYKGYDDg0XEoDz1jnfp7mq+wI5Gm5PZZB2HbyOh1rUwxlI19+7Lt+RYYcQWm79qy6LP10OZkuHrY/0sGb+Yc/HCFaNpADQjKHVzqdF7TLTX5uGSTmjU1ZNh34OzP7AF1Sl5EaD3GUKeD5EFPJ9+SDYTawQk9xDYE3fYYdgVW/1y5ad2oOo0rA7MAXccXk6KJChp2WuPPULif8INVQnQsVKBE+YdUar9/EZWtLZ9Tq7xzEr/PKVWtJF7VfXHiYDuzLmJBc+N7JxjcKqk7Xug10SyB9tamsDX0AA3ABVcYZ7rVH1+aZCYrb4J9MAmpY3LnZ4FlLKanBjMjP+2WL4QZTTFVRXNpYWn8A6f5+O/wCrxCNAdqHJIWPlN1Aex7EYSWbC72CtHOj8oSQ==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Qzg5Ylo0UjhqcXdvRzl1MHQxNjVpTlZuWDVVV3ZQTjllRmtsR3BTM2NaM2FV?=
 =?utf-8?B?cThSTDloMDRXcTFLSnpmMFN4cDFHSFE3YWF4RFZQWndrOFJqVGpJaHUvRmh3?=
 =?utf-8?B?YUcvRWUwZm5mSkNuYmtHS1R4eG5hMk9wOUFTWlo3eExmWEwrSUFDUEZSdXEy?=
 =?utf-8?B?NDUydUd0aElQbC9TWWlPSEJUVm1yTTJqaEwzdEpZY1IxcGh2NmZtYnplK1Vs?=
 =?utf-8?B?Sk9xRjNVbFJKdGhjRysyR0QxaGpZdEpzWTBsU2s5QTZ6emdnNU1PYlg4SDNE?=
 =?utf-8?B?VE1mRFBxSUVoaGY0c2tFWWdJZFVvTWpDcWpkakk0TlZyN3E0TlYxRkhHamVu?=
 =?utf-8?B?NENCWlNIUVhmemROd1daZUtZRHhmVTdxQzFWZTRuWHFHR3N6VTJhMnhRbjU3?=
 =?utf-8?B?SUdLNHBYYmtPMDEzSHBsK04xbGh1LzZxWEgyN1BYbU5hODlQTit5djB2cnQx?=
 =?utf-8?B?bHdEYlVrbTJnUnFWYm4rR3dLZUVLTFh3KzI4RndzdzhoSFF5TEk1azNlSENa?=
 =?utf-8?B?QnRKSzFqZE9GN0N1d2lJSGNDN3RJdVpzTDFwZ01GZjY0akV0cEhFbDdmZE9v?=
 =?utf-8?B?d0JLWUVuYlBGTlpLMnZQMFlQeDFvV1JVd1Z5bzBzOHZhTjlBV0drdjJHVVF3?=
 =?utf-8?B?T2pUM2xaTU9HaVRRcHhvUEZ6NHpHZ2NWUUs4Mm9MeHpMUU90d2NzcktVNStt?=
 =?utf-8?B?b0NLamFMa1c5N290Z093eXhpY2NhZm5YNWtybWVoZTN6VU5nVG5wTUVPc2wy?=
 =?utf-8?B?eTVhd1IxaU5mM3k1M1NvaS9ucWxZOU1xbUh1a1R3M3RGeDh0U0MzZzFmcE5Q?=
 =?utf-8?B?c0ZkSk54empnendZM1RGWkQzaUE5Nk03SVN1dHhoQ1k2ZThyUjRQTWp3NGE1?=
 =?utf-8?B?dTROMGc5ZThpdDFZVWtrM0l6eVQyZ0RMK1hJZlFZSXhMUHR2by9TQnZXVnFy?=
 =?utf-8?B?RUp1SkdZVUJzQUd6UnNSUkFMMDA2dWFzcVBqZDZQUGlCNnVHbERMM005NWlv?=
 =?utf-8?B?b2JzSHNFMUsvbENNMlBxd0E5ckxEUi9IODBBQ05TUUsxR0V4djUwMFAvZUpP?=
 =?utf-8?B?dDZDMGZiaURwS2lEZnFpNWsrQ2loN0hFZFhJVG94L2FtM25Yc29OMEd3VDIw?=
 =?utf-8?B?Sy8xTzBwdVUwbFpZYTZEK1UyNDAremQyRlVzaW1Sb2VqeDFEU0FiYmc5V2w4?=
 =?utf-8?B?UzFKQ2IwcU9keU9PWTV2T2V5S2VxUDBydm9MWWNHREZRdkdkbjV4UHJnT3gr?=
 =?utf-8?B?QjZsZDV4d1l0dmVjVFdIZ0l5RFFiWWtHTW4vVkZ3WkcvUXo5NGJqNlhnL2RU?=
 =?utf-8?B?Ky9FS052RUdEOU9ZRlpOTStBSlZsVVp3Z3ZCOVVuZnBtN1JwUFBnWDJ2eFQ1?=
 =?utf-8?B?bWY3MW5iU2V2bHpZREdRUVhkSTFjTDIrZGVXWlJGdVNSUUVHN2JZVWg4bXcv?=
 =?utf-8?B?Rk9WUmZqT0JnTCtmd0VSamhIWjBLRFMzZkNHWXNWbytnN0F1MXZabDB5WXJL?=
 =?utf-8?B?WkhKeFZJNHJpUUxZWWZTTVlWQjFjS0I0Y1YxLy80Y0ZvMzdhVGxnZ0FCandI?=
 =?utf-8?B?eHlYOUVqSGs3VEVWakVTRm9kOUZ4aXdpY2FyNGloNzAvc0lQdnFnWHROaFlF?=
 =?utf-8?B?NmdwdmhzYWN6V1FoN2V2YUhmb0VQZXVQQkZFSGp6eUROVG5tT3VZeGVIcG5L?=
 =?utf-8?B?Q1RwNHRwYm1OMThMbmxkck16d2VPU3hBcTRjYXVsNmtPbzVlQ3RnZVE5b0Jx?=
 =?utf-8?B?VGtYTTQ5MmFLYmxVVmdGZXNHRlFvMVRaM1RXLzlORDgyQ0F0dThGS2NaT0JM?=
 =?utf-8?B?dnh3cTByRC9RNTVlUnUxUT09?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-edb50.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 42ef7061-b2f9-42d6-118c-08da5d5bb762
X-MS-Exchange-CrossTenant-AuthSource: DM5PR04MB0251.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 01:22:53.1074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4056
Subject: Re: [PHP-DEV] [RFC] Add json_encode indent parameter
From: pleasestand@live.com (Kevin Israel)

On 7/3/22 18:01, Jakub Zelenka wrote:
>   I think we can put this RFC to the vote. If the author is to busy I would
> like to start voting later this week. It would be a pity not to make it to
> feature freeze as it is quite straight forward and the implementation seems
> good as well so I guess we don't need to wait extra year. :)
>
> Cheers
>
> Jakub
>
This RFC really should have included an option to use tabs instead of 
spaces, which is, IMO, even more important than having a parameter for 
the number of spaces. This could take the form of either

(a) a magic indent value such as -1, or

(b) a new flag (suggested name: JSON_INDENT_USING_TABS).

There should be no need to support indenting using multiple tabs per 
level; for option (b), the value of the indent parameter should be ignored.

An indent-using-tabs flag would even be useful for generating two-space 
indented JSON, should the proposed indent parameter be rejected. The 
reason is that tabs cannot occur within JSON string representations, so 
any other indent string is a simple str_replace() away. In contrast, 
replacing the current four-space indent with anything else is more 
complicated to do efficiently[1].

[1]: 
https://github.com/wikimedia/mediawiki/blob/210a34369ac8f0ba74b497d0b2298ca7e5a0bffb/includes/json/FormatJson.php#L113-L117