Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118144
Message-ID: <90ccccc1-3129-556e-2224-6a3b4164b047@gmail.com>
Date: Thu, 30 Jun 2022 20:48:07 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-GB
To: internals@lists.php.net
References: <2b35605f-8da8-46b1-aec3-00bd1bfe47fd@www.fastmail.com>
 <7513519.rnE6jSC6OK@arnaud-t490>
 <CAC5V6gjk6T_XupP8aRr0TYEH9BCoaEJUr737St5c4YKUb02O5Q@mail.gmail.com>
 <5584889.DvuYhMxLoT@arnaud-t490>
In-Reply-To: <5584889.DvuYhMxLoT@arnaud-t490>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Short Closures 2, aka auto-capture take 3
From: rowan.collins@gmail.com (Rowan Tommins)

On 30/06/2022 18:37, Arnaud Le Blanc wrote:
> On jeudi 30 juin 2022 18:29:44 CEST Guilliam Xavier wrote:
>> Ah? Sorry, I had interpreted
>> https://github.com/php/php-src/pull/8330/files#diff-85701127596aca0e597bd796
>> 1b5d59cdde4f6bb3e2a109a22be859ab7568b4d2R7318-R7320 as "capture the
>> *minimal* set of variables for *both* arrow functions and short closures",
>> but I was wrong?
> No, you are right, the PR changes arrow functions too. But in the RFC we
> decided to not touch the arrow functions for now.


Personally, I would be in favour of leaving the change in for arrow 
functions as well. The fact that a variable of the same name, whose 
value is never actually used, is captured by the closure, is to me a 
bug, not a feature.

It's hard to even contrive an example where this is observable, so I 
highly doubt anyone is relying on it.

Regards,

-- 
Rowan Tommins
[IMSoP]