Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118108
Message-ID: <4511aee0-b5a0-6310-270f-38ae5cfd8a06@gmail.com>
Date: Mon, 27 Jun 2022 16:50:54 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CAOfKkdTjPiZHnSHuag_+fmFK-1Advh2-vfDgbJBXEmK=72NB0g@mail.gmail.com>
 <CABdc3WryiOY=3cMTdi+gVxbE+twi8ixJGtG9Gfa+4RfJQT5DhQ@mail.gmail.com>
 <CAOfKkdRv7OgCDt4Str3sP3Nsfqc3+F1r3OS80s+DDFFnidxy0A@mail.gmail.com>
In-Reply-To: <CAOfKkdRv7OgCDt4Str3sP3Nsfqc3+F1r3OS80s+DDFFnidxy0A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] New Curl URL API
From: rowan.collins@gmail.com (Rowan Tommins)

On 27/06/2022 14:10, Pierrick Charron wrote:
> The purpose of the CurlUrl class is to be able to build/see/modify an URL
> as it is seen by libcurl before/after passing it to your CurlHandle. It is
> not meant to be used alone as a representation of an URL.
>
> For example, you may want to do some checks to make sure that the URL you
> gave to your CurlHandle is well formatted and that the host or any other
> parts are what you want them to be, and that it was not something else
> because of some differences on how the URL was parsed. Or you may want to
> add/delete/overwrite some parts to sanitize your URL. That's why you have
> those setters/getters. This class is definitively not there to replace
> PSR-7 UriInterface. I can imagine some Guzzle or other implementation to
> build a CurlUrl handle from a UriInterface before giving it to curl.


This leaves me a bit baffled, frankly.

If I've got a URL, which is already a string, what code would I write to 
"do some checks" on it, outside of a unit test?

If I'm using CurlUrl to "add/delete/overwrite some parts" how is that 
not "using it alone as a representation of an URL"?

If I'm writing a PSR-7 object, am I only supposed to use CurlUrl when 
interfacing with curl, and generate the string myself for other 
purposes? If the implementation I come up with differs from curl's, how 
does the user know which is the "real" URL?


Regards,

-- 
Rowan Tommins
[IMSoP]