Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118107
MIME-Version: 1.0
References: <CAOfKkdTjPiZHnSHuag_+fmFK-1Advh2-vfDgbJBXEmK=72NB0g@mail.gmail.com>
 <CABdc3WryiOY=3cMTdi+gVxbE+twi8ixJGtG9Gfa+4RfJQT5DhQ@mail.gmail.com> <e06af338-a4fb-5dc5-6aae-78a4a6d1ea7c@gmail.com>
In-Reply-To: <e06af338-a4fb-5dc5-6aae-78a4a6d1ea7c@gmail.com>
Date: Mon, 27 Jun 2022 09:18:05 -0400
Message-ID: <CAOfKkdT7eigfMBLwJd5ZfEdbu4Qt0KMQeJr3W=kGyvY5Ub=BPA@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000bbed8005e26dc03c"
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] New Curl URL API
From: pierrick@php.net (Pierrick Charron)

--000000000000bbed8005e26dc03c
Content-Type: text/plain; charset="UTF-8"

Hi Rowan

>
> Rather than a *representation* of a URL, think of the class as a
> *builder* for URLs. There are multiple methods because you might want to
> build the URL in different orders ("start with this URL but replace the
> port", "start with this domain and I'll add the path later", etc). All
> the flags are related to how the input should be interpreted, and the
> output manipulated, in order to build a correctly formatted URL string.
>

Sorry if it was really not clear in the RFC since I didn't even talk about
the CURLOPT_CURLU option, but this class is not only there to parse/build
strings for Curl but to give this specific object to Curl instead of a
string representation of an URL.


>
> Maybe it should even be called CurlUrlBuilder? That also fits with the
> design of having mutable setters; as Derick pointed out, mutable value
> objects are generally a bad idea, so it would make sense to encourage
> users to think of this as a way to get one or more strings, rather than
> as a result in itself.
>

Since you can give this object to curl instead of an URL string, I would
not call it CurlUrlBuilder.

Regards,
Pierrick

--000000000000bbed8005e26dc03c--