Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118102
Message-ID: <e06af338-a4fb-5dc5-6aae-78a4a6d1ea7c@gmail.com>
Date: Mon, 27 Jun 2022 09:05:22 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CAOfKkdTjPiZHnSHuag_+fmFK-1Advh2-vfDgbJBXEmK=72NB0g@mail.gmail.com>
 <CABdc3WryiOY=3cMTdi+gVxbE+twi8ixJGtG9Gfa+4RfJQT5DhQ@mail.gmail.com>
In-Reply-To: <CABdc3WryiOY=3cMTdi+gVxbE+twi8ixJGtG9Gfa+4RfJQT5DhQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] New Curl URL API
From: rowan.collins@gmail.com (Rowan Tommins)

On 27/06/2022 07:29, Michał Marcin Brzuchalski wrote:
> CurlUrl is for me is a mix of Url/Uri object properties well known from
> other userland implementations like the PSR one
> with Uri specific like the host, scheme, port, path, query, fragment, etc.
> but on the other hand, we have flags and options which
> purpose is to pass Curl specific things but in IMO wrong place


Rather than a *representation* of a URL, think of the class as a 
*builder* for URLs. There are multiple methods because you might want to 
build the URL in different orders ("start with this URL but replace the 
port", "start with this domain and I'll add the path later", etc). All 
the flags are related to how the input should be interpreted, and the 
output manipulated, in order to build a correctly formatted URL string.

Maybe it should even be called CurlUrlBuilder? That also fits with the 
design of having mutable setters; as Derick pointed out, mutable value 
objects are generally a bad idea, so it would make sense to encourage 
users to think of this as a way to get one or more strings, rather than 
as a result in itself.

Regards,

-- 
Rowan Tommins
[IMSoP]