Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118101
Feedback-ID: i6f4c46c2:Fastmail
Message-ID: <18a384bd-9ac3-728d-85b8-36280db116ea@beccati.com>
Date: Mon, 27 Jun 2022 09:39:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CA+kxMuSKYP=favj31kjwkWGC0WWY5rT+RD6H20evQejkr-Nuxw@mail.gmail.com>
 <acd468ee-a045-2186-2f85-4752e1bd9e1b@mabe.berlin>
Cc: Marc Bennewitz <marc@mabe.berlin>
In-Reply-To: <acd468ee-a045-2186-2f85-4752e1bd9e1b@mabe.berlin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific
 sub-classes
From: php@beccati.com (Matteo Beccati)

On 27/06/2022 08:50, Marc Bennewitz wrote:
> 2. Another annoying PDO feature is the configurable behavior of exceptions.
> As now exceptions are the default way it would be nice to not all 
> disabling exceptions if instantiated the new way.
> 
>  > Create all DB sub-classes?
> 
> yes please

I too think this would be best for consistency.


>  > PQescapeIdentifier
> 
> I think these should be a general PDO method but as we already have 
> `quote` it would be preferable to name it `quoteIdentifier` or how would 
> you explain the difference between `quote` and `escapeIdentifier`?

I haven't checked the feasibility, but how about a PDO::QUOTE_IDENTIFIER 
constant to be used only with the existing quote method?

e.g.
PDO::quote('A column name', PDO::QUOTE_IDENTIFIER)


That said, I have the feeling this RFC suffers from feature creep and is 
subject to a fair amount of bike shedding. To me that's a bit too late 
for 8.2.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/