Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118090
MIME-Version: 1.0
References: <CA+kxMuSKYP=favj31kjwkWGC0WWY5rT+RD6H20evQejkr-Nuxw@mail.gmail.com>
 <62b1d83c.1c69fb81.3d597.8aa9SMTPIN_ADDED_MISSING@mx.google.com> <CA+kxMuQdXmPysC9x_Np+6XOumOcsdqgMcmf7-toBC0M_pejezQ@mail.gmail.com>
In-Reply-To: <CA+kxMuQdXmPysC9x_Np+6XOumOcsdqgMcmf7-toBC0M_pejezQ@mail.gmail.com>
Date: Fri, 24 Jun 2022 17:23:32 +0100
Message-ID: <CALKiJKru50ED-ZAth77sNPO67tXJaVvUE4ZLTNGO3d06GG+Ywg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007e5f6c05e233fe3b"
Subject: Re: [PHP-DEV] Re: [RFC] [Under Discussion] PDO driver specific sub-classes
From: rowan.collins@gmail.com (Rowan Tommins)

--0000000000007e5f6c05e233fe3b
Content-Type: text/plain; charset="UTF-8"

On Fri, 24 Jun 2022 at 16:38, Dan Ackroyd <Danack@basereality.com> wrote:

> YAGNI, and I'm lazy. But mostly, I don't think adding them now
> actually helps achieve anything.
>


Fair enough, but as a minimum there should be an internal API for
registering a sub-class, without any modification to ext/pdo.

For instance, it should be possible to modify
https://github.com/microsoft/msphpsql to define a PDOSqlServer class and
have it returned by PDO::connect when a relevant DSN is provided.

It looks like the current PR implements everything directly in ext/pdo,
which feels like a broken abstraction; the SQLite-specific functionality
should all live in ext/pdo_sqlite.

Regards,
-- 
Rowan Tommins
[IMSoP]

--0000000000007e5f6c05e233fe3b--