Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118086 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 38485 invoked from network); 24 Jun 2022 13:35:22 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Jun 2022 13:35:22 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 6B4B8180543 for ; Fri, 24 Jun 2022 08:25:24 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 24 Jun 2022 08:25:24 -0700 (PDT) Received: by mail-vk1-f172.google.com with SMTP id n203so1377737vke.7 for ; Fri, 24 Jun 2022 08:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=basereality-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dra1K1JVgkgQYutaEwvGSsIlrLRd9K+Njd0p31iXR+g=; b=4rcg3mdtyHneB3w1LOp+gCMMhs3PrkHrtn4ckFI5dKKMVLOQav46wrRK9ofhU6n+yx rlIkANIagZJV6mKNYHAUflghhy3NrbW3XepK6AWfkQSRdWWOFvKn7jFmM/MdS1LhOfIa nQ1KKJTIgOL9kXR7M2VXH058DF5TkJwljF9t41qZ7gJPDPGUhoWPnlumMkrJ0z01Zbex 2qqv34vpVmVcJLx5vcu2VgCKpNG9X+1X6IjMp92qK//GNBoQmUdzyj0SnwJR1biflbwT ztnDMoYNi+k9Iv3aIuEomfJLkoSmD207KPlMlQ3mVImkybj5D5Qj+lv9hLGF15pXWBXY ZFwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dra1K1JVgkgQYutaEwvGSsIlrLRd9K+Njd0p31iXR+g=; b=a1ePjbaLFatFnDfw26Oha2T/A8zWIvLnARZ89ZOvUfF8hzzuMLG6SEpyxCuy95p9Rf wtVElhlnawAdnAykO/RgpibjZJ/uA3WkgVfIYfIZgyFKxLQXsbmYevNZV0BU/h5uHuTb uVCI+DT0fGIdu8R3SWxiHbbDicbPqT2gJchqr9jGA0n1i9L9LI0o1fbV+zN+5sOCOak3 1t5vhnWfy9tYvv46uYhFYc3vwDyQWGRUdrlmqK9qEQsqH6DnOe58/lmiWeBUXfAhYsyW dB3lCkFG0PukfKzSF/TkfDD08lfy+QeqdEkIy+6OGXiILf+XvQRGIl/pDmm3KPS/yRuW vdPw== X-Gm-Message-State: AJIora86lOlEOb4vBfz03ziYTtUORFojRkGtJ+5CbsDn8BuDr2bSg8jN 6GX+J/al7GV0XmMMyTxHKDRAMoEoRowk0c06Ltl9e/LwamBACQ== X-Google-Smtp-Source: AGRyM1sQtGVIGXdjPHnXBeDJUWEAv/LE4vOFRk/YNPeema1e0wJExEQKpF+sRD445VxL41cAuQmm9jqfR72iWXMhlF4= X-Received: by 2002:ac5:cff3:0:b0:36b:f6ce:430c with SMTP id m51-20020ac5cff3000000b0036bf6ce430cmr15486097vkf.16.1656084323470; Fri, 24 Jun 2022 08:25:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Fri, 24 Jun 2022 16:25:10 +0100 Message-ID: To: Rowan Tommins Cc: internals@lists.php.net Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] [RFC] [Under Discussion] PDO driver specific sub-classes From: Danack@basereality.com (Dan Ackroyd) On Tue, 21 Jun 2022 at 10:41, Rowan Tommins wrote: > > The implementation MUST be written by > someone with intimate knowledge of the DBMS in question, or it cannot be > trusted. Well, that rules me out of doing it. > So if we only have a Postgres implementation right now, we should either > implement quoteIdentifier only on PDOPostgres I'll expose it as a method on the PDOPostgres class. Having a quote identifier function on the PDO class itself that does the appropriate thing for all of the databases will be for another RFC, so that is also added to future scope. cheers Dan Ack