Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118049
MIME-Version: 1.0
References: <CAOfKkdTjPiZHnSHuag_+fmFK-1Advh2-vfDgbJBXEmK=72NB0g@mail.gmail.com>
 <7CB0EB0B-700D-49F6-8223-00A9B16F463B@php.net> <CAOfKkdTKuj3nbi7ORMzpYDE2Yn5aKX-E64JdH2PR4qDXqfPiAg@mail.gmail.com>
In-Reply-To: <CAOfKkdTKuj3nbi7ORMzpYDE2Yn5aKX-E64JdH2PR4qDXqfPiAg@mail.gmail.com>
Date: Wed, 22 Jun 2022 16:46:04 +0200
Message-ID: <CAJmy8YGCOLaZSt5s=RQVD+uKDbVrwYBYZjQS4gLRLkkVjZ0nqw@mail.gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000aab29005e20a67a8"
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] New Curl URL API
From: divinity76@gmail.com (Hans Henrik Bergan)

--000000000000aab29005e20a67a8
Content-Type: text/plain; charset="UTF-8"

any particular reason CurlUrl::getPort() defaults to 0 rather than one of
the valid options? (that being CurlUrl::DEFAULT_PORT
and CurlUrl::NO_DEFAULT_PORT )

On Wed, 22 Jun 2022 at 16:23, Pierrick Charron <pierrick@php.net> wrote:

> Hi Derick,
>
>
> >
> > - The new CurlUrl class should probably be immutable from the start. It
> > was my biggest mistake not to do that with DateTime.
> >
> >
> Thanks for sharing your lessons learned. But I still see some use cases
> where mutable objects are easier to use. From the experience you had with
> DateTime, do you think that having `CurlUrl` being immutable and providing
> a `MutableCurlUrl` would make sense ? I see some cases where you "navigate"
> on a website using the same CurlHandle and just want to manipulate the
> MutableCurlUrl handle to change urls.
>
>
> > - What happens if the curl library available on the system does not have
> > the features and functions that this new class relies on? I would expect
> > the class to not be available either, but the RFC does not mention that.
> >
>
> Good point. As you expected, if the functions are not available in libcurl,
> the class will not be available. Same thing for each constant/feature. The
> extension will "adapt" to the curl version. I will add this to the RFC.
>
> Pierrick
>

--000000000000aab29005e20a67a8--