Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118026
MIME-Version: 1.0
References: <CAOfKkdRzoo7JuD07F8nkZBYvS5eDMiV2r6cNV-FgeLxBrdCsiQ@mail.gmail.com>
 <CAESVnVpzqT0xtEShqQp+FPXt2DQjeAXpkSVZTACAC0CW=8FBBg@mail.gmail.com>
 <CAOfKkdTu1f6jJ2HwGjOnBR2sO6P6qdOrjH1ZzumwLzf1syXa6Q@mail.gmail.com>
 <76FA5161-16C3-4570-9EF8-B75DF2E6530A@gmail.com> <CAOfKkdQGX5Lf5-jKyKnh5im9YYd-pKPx=AxnLgk9=tBoJ37E9Q@mail.gmail.com>
 <5758628b-197f-000c-bfbf-8b6884b11223@gmx.de> <6d24947d-e004-1354-a608-b344b4f151a5@gmail.com>
In-Reply-To: <6d24947d-e004-1354-a608-b344b4f151a5@gmail.com>
Date: Mon, 20 Jun 2022 17:59:12 -0400
Message-ID: <CAOfKkdRGjDncfYxobfY-1Sd3OpbGJbL5dfMTD64FvO47XKQ=kw@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000007de05a05e1e83782"
Subject: Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements
From: pierrick@php.net (Pierrick Charron)

--0000000000007de05a05e1e83782
Content-Type: text/plain; charset="UTF-8"

>
>
> I haven't read back through the thread, but my impression was that *for
> the curl URL facility specifically* the opposite was the case: a simple
> object with no procedural equivalent would be everyone's preference.
> CurlFile provides enough of a precedent for adding that IMO.
>

+1


>
> Either way, we have to agree on some naming details, so I've left some
> comments on the PR.
>
>
Your suggested names were good, so I used them except for
`NON_SUPPORT_SCHEME` that I replaced with `ALLOW_UNSUPPORTED_SCHEME`.


> (By the way, the PR you linked is to merge into your own fork's master,
> not the actual central php-src repo. Not sure if that was deliberate.)
>

I didn't do it intentionally. Sorry about that.

Regards
Pierrick

--0000000000007de05a05e1e83782--