Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118023
Message-ID: <5533d807-949b-0759-b13e-fec9b44d7ef7@bastelstu.be>
Date: Mon, 20 Jun 2022 19:00:02 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Go Kudo <g-kudo@colopl.co.jp>, Marc <marc@mabe.berlin>,
 internals@lists.php.net
References: <CAMs36HcGzvwwTTU+nUO+U_M6o4qpOAHES7RbHEJWm6iot+-9=Q@mail.gmail.com>
 <d4552bdb-8a1c-4efa-9cd6-21db0160c185@email.android.com>
 <CAMs36HfkcUEuS_1TzW=AddDjvP-J=2KHzpocetPZSufWWRY8Vw@mail.gmail.com>
In-Reply-To: <CAMs36HfkcUEuS_1TzW=AddDjvP-J=2KHzpocetPZSufWWRY8Vw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 6/20/22 07:20, Go Kudo wrote:
> What about a signature like `Randomizer::pickArrayKeys(array $array, int
> $num): array`?
> The previous behavior when `int $num` is 1 can be easily reproduced as
> follows:
> 
> ```php
> $randomizer = new Random\Randomizer(new Random\Engine\Mt19937(1234,
> MT_RAND_PHP));
> [$key] = $randomizer->pickArrayKeys(['foo', 'bar', 'baz'], 1);
> ```php

I like that one.

>> If multiple keys are returned, they will be returned in the order they
> were present in the original array.
> 
> Perhaps there is no particular significance to this specification. I don't
> think it is necessary, but considering the drop-in replacement from
> array_rand(), I think it is desirable to leave it as is.

I agree.

Best regards
Tim Düsterhus