Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118020
MIME-Version: 1.0
References: <CAMs36HcGzvwwTTU+nUO+U_M6o4qpOAHES7RbHEJWm6iot+-9=Q@mail.gmail.com>
 <CAOWwgp=t93i6j=hOQ+z1swoRKDh7Ay5-ty=31pEv84y5rhbekg@mail.gmail.com>
 <CABTDVhA6wSb04OEONuNP447yDDDQVRpyYH4h9pNLP_6kkVP9Gg@mail.gmail.com> <3fc08765-1419-76ff-d0a6-bf4552dfdc2f@bastelstu.be>
In-Reply-To: <3fc08765-1419-76ff-d0a6-bf4552dfdc2f@bastelstu.be>
Date: Tue, 21 Jun 2022 01:03:42 +0900
Message-ID: <CABTDVhCKy7xz=z4zHBu9Vy=nY52+0AnKEgu-OW9ExgC+7Mdk2g@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000273d1505e1e340f8"
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement
From: zeriyoshi@gmail.com (Go Kudo)

--000000000000273d1505e1e340f8
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B46=E6=9C=8821=E6=97=A5(=E7=81=AB) 0:42 Tim D=C3=BCsterhus <tim@=
bastelstu.be>:

> Hi
>
> On 6/20/22 17:12, Go Kudo wrote:
> >> CombinedLCG
> >
> > This is provided as an OOP implementation for the `lcg_value()` functio=
n,
> > but I don't actually
> > want it to be used anymore, so I probably shouldn't provide a class for
> it.
> >
> > And to begin with, the current CombinedLCG cannot even be seeded with
> > arbitrary values.
> >
> > However, I think it needs to remain in the internal API either way. (Th=
e
> > option of not providing
> > it to userland is a valid one.)
>
> I wouldn't object to dropping CombinedLCG, especially since its internal
> parameters are not defined via the name (contrary to MT19937).
>
> > What do you think about the `Random\CryptoSecureEngine` interface?
> > It is just a marker interface with no methods.
> >
> > However, I currently think it is better than adding a method like
> > `isSecure(): bool`
> > to the `Random\Engine`.
> >
>
> I *much* prefer the marker interface.
>
> Best regards
> Tim D=C3=BCsterhus
>

Hi

Added option to discontinue CombinedLCG.

https://wiki.php.net/rfc/random_extension_improvement

I am struggling with the following issue:

1. change `Randomizer::pickArrayKey(array $array, int $num =3D1):
int|string|array`
to `Randomizer::pickArrayKeys(array $array, in $num): array`.

2. Change the class name to "Always PascalCase" or "PascalCase except
Acronyms".

I hope I can solve the discussion by e-mail, but if I can't, I will further
add it to the RFC options.

Best regards,
Go Kudo

--000000000000273d1505e1e340f8--