Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118013
MIME-Version: 1.0
References: <CAMs36HcGzvwwTTU+nUO+U_M6o4qpOAHES7RbHEJWm6iot+-9=Q@mail.gmail.com>
In-Reply-To: <CAMs36HcGzvwwTTU+nUO+U_M6o4qpOAHES7RbHEJWm6iot+-9=Q@mail.gmail.com>
Date: Mon, 20 Jun 2022 16:57:49 +0200
Message-ID: <CAOWwgp=t93i6j=hOQ+z1swoRKDh7Ay5-ty=31pEv84y5rhbekg@mail.gmail.com>
To: Go Kudo <g-kudo@colopl.co.jp>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000885e6005e1e254d8"
Subject: Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension Improvement
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--000000000000885e6005e1e254d8
Content-Type: text/plain; charset="UTF-8"

> An RFC has been created to fix an issue in Random Extension 5.x.
>
> https://wiki.php.net/rfc/random_extension_improvement
>
> Voting on this RFC will begin in two weeks (2022-07-02), in time for the
> PHP 8.2 Feature Freeze. (Vote finished in 2022-07-16, Feature Freeze is
> 2022-07-19)
>
> In the unlikely event that the Random Extension 5.x RFC is rejected, this
> RFC will become invalid regardless of the outcome of the vote.
>

Hi, thanks for the update, that makes sense to me.

I'm wondering: does Random\SerializableEngine extend Random\Engine? Can
this be mentioned in the RFC? If not, what about making it this way? Having
this interface only contain __(un)serialize would look strange to me, aka
too broad for the name and the purpose.

I'm also wondering: is CombinedLCG worth it? I must admit I don't know when
I should use it instead of MT19937.

Since the names are all super opaque to many of us, documentation should be
very clear about the use case of each implementation... (if can reduce the
number of implementations, that's even better :) )

Cheers,
Nicolas

--000000000000885e6005e1e254d8--