Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118006
MIME-Version: 1.0
References: <b818fb49-ef47-c1d2-eff9-675f8469034c@bastelstu.be>
 <CAC5V6ghChmo91F0dm7eOyGcvr7Pp2KguDwO=5LFCX+2Nbh2jbA@mail.gmail.com> <4af09139-7db0-e701-69e0-de527afcfc6c@bastelstu.be>
In-Reply-To: <4af09139-7db0-e701-69e0-de527afcfc6c@bastelstu.be>
Date: Mon, 20 Jun 2022 14:07:48 +0200
Message-ID: <CAC5V6gj+QLPPfSeri0p_80aa7DVzXxXB4j0zjBo_ddh63Wkhnw@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Make iterator_to_array() accept all iterables
From: guilliam.xavier@gmail.com (Guilliam Xavier)

On Fri, Jun 17, 2022 at 7:21 PM Tim D=C3=BCsterhus <tim@bastelstu.be> wrote=
:
>
> Hi
>
> On 6/17/22 18:06, Guilliam Xavier wrote:
> >>     https://github.com/php/php-src/pull/8819
> >
> > Just so that it can't be said that it hasn't been asked: what about
> > iterator_count(), and iterator_apply()?
>
> I also came across those, while implementing the PR, but I intentionally
> did not touch them to keep the scope simple and because I think they are
> less likely to be used generally.

Okay :)

> - `iterator_apply()` is easily replaced by a foreach loop, because the
> return value is pretty useless, so it is not likely that a nested
> function call is going to be used.

Well the same could be said about `array_walk()`... but anyway :p

> - For `iterator_count()` one could to `count(iterator_to_array($foo))`
> if my proposal is merged. This come with a bit of overhead, but at least
> it's not as clunky as `is_array($foo) ? $foo : iterator_to_array($foo)`

or as `is_array($foo) ? count($foo) : iterator_count($foo)`, for that matte=
r ;)

> If a RFC is desired, then I'd likely include all three of them with a
> vote for each, but I hope my proposal is simple enough to not require an
> RFC.

Well I won't be the one asking for an RFC ^^ (and you're right that
the `array_*` functions are far more numerous and [at least in my
experience] used than the `iterator_*` ones)

--=20
Guilliam Xavier