Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118000
MIME-Version: 1.0
References: <CAOfKkdRzoo7JuD07F8nkZBYvS5eDMiV2r6cNV-FgeLxBrdCsiQ@mail.gmail.com>
 <CAESVnVpzqT0xtEShqQp+FPXt2DQjeAXpkSVZTACAC0CW=8FBBg@mail.gmail.com>
In-Reply-To: <CAESVnVpzqT0xtEShqQp+FPXt2DQjeAXpkSVZTACAC0CW=8FBBg@mail.gmail.com>
Date: Sat, 18 Jun 2022 22:53:17 -0400
Message-ID: <CAOfKkdTu1f6jJ2HwGjOnBR2sO6P6qdOrjH1ZzumwLzf1syXa6Q@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008e6e2f05e1c41721"
Subject: Re: [PHP-DEV] Discussion about new Curl URL API and ext/curl improvements
From: pierrick@php.net (Pierrick Charron)

--0000000000008e6e2f05e1c41721
Content-Type: text/plain; charset="UTF-8"

Hi Sara


> This is so bizarre, I *know* I wrote an OOPified cURL extension some years
> ago (called it curli), and now I can't find it anywhere.  What universe am
> I even in?
>

I don't know but if you pass through the parallel universe where Curli is,
I'm interested.


>
> Anyway, +1 on making a whole new OOPified cURL implementation.    $ch =
> (new CurlHandle($uri))->setOpt(Curl::OPT_METHOD, 'post')->perform();
> Let it throw exceptions, do proper type checks, all the goodness.  Let the
> procedural APIs behave differently than the object methods and that's okay.
>
> cURL is a foundational extension in PHP and I respect the choices that
> were made in its API design, but it's 2022, and we deserve a better
> ext/curl.
>

I hope you don't mind, I took some of your code from your "Enable
strict_types checking for curl_setopt()" pull request [1] to do some test
on introducing this but only on the OOP API. It's working very well [2].
Can I know why this PR was closed ? Any issues ? Or was it more because it
was too much of a change for the procedural API ?

Thanks
Pierrick

[1] https://github.com/php/php-src/pull/2495
[2] https://github.com/adoy/php-src/pull/2

--0000000000008e6e2f05e1c41721--