Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117992
MIME-Version: 1.0
References: <CAMs36Het5f=ojSw8H4kooZxub-COvhKmiJfYUUM7ioBSpVKFVA@mail.gmail.com>
 <CAMs36HewSTHNubys+Ss4rTbTWQE4vWyXL5OJLP8nMnrJ3GijKA@mail.gmail.com>
 <77a64074-875c-cfd6-5811-24b9d445f550@bastelstu.be> <CAMs36He2os0Fuw-qDTeMYkeuJQw-rqKmVm52-vb5j0drp5k6vA@mail.gmail.com>
 <3aac541e-b80d-1106-369f-a00a3a718f90@bastelstu.be> <CAMs36Hdon9RHP+GOM=Rbkaie85Q4_LCnmqFmpLPOk9cthEYFoQ@mail.gmail.com>
 <59852986-8988-4eaf-d88d-953d6c0b9f43@bastelstu.be>
In-Reply-To: <59852986-8988-4eaf-d88d-953d6c0b9f43@bastelstu.be>
Date: Sat, 18 Jun 2022 03:37:28 +0900
Message-ID: <CAMs36Hfsb3O0GcB+T-4z3j+hjwTsGxqp38SBT5VFBtR3ABzJAg@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000007eff2805e1a90c22"
Subject: Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x
From: g-kudo@colopl.co.jp (Go Kudo)

--0000000000007eff2805e1a90c22
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B46=E6=9C=8818=E6=97=A5(=E5=9C=9F) 3:13 Tim D=C3=BCsterhus <tim@=
bastelstu.be>:

> Hi
>
> On 6/17/22 19:46, Go Kudo wrote:
> > I was fundamentally wrong, I understand now.
> > As you said, there was no interoperability with `pickArrayKey()` in the
> > first place...
> >
> >> stringFromAlphabet()
> >
> > Hmmm. I guess randomString would be better then. At the same time, it
> would
> > be nice to have an array version of randomArray.
> >
> > However, I don't want to add more methods without any thought.
> > I think operations that can be done on userland should be done on
> userland.
> > That is why I did not implement the array_rand() function in the first
> > place.
>
> Yes, I agree here. But I believe that "generate a string with a given
> alphabet" is a very common operation that would be useful to include in
> the standard library. In any case it's better to leave something out
> than to implement something badly, so if you don't feel comfortable with
> that, then leave it out. There will be more PHP versions after 8.2.
>
> For me both of these:
>
> ->randomString(string $alphabet, int $length)
> ->stringFromAlphabet(string $alphabet, int $length)
>
> with the description "Return a string of $length characters selected
> from the given $alphabet. Characters may be selected more than once".
>
> would be acceptable names.
>
> Best regards
> Tim D=C3=BCsterhus
>

I noticed one important thing. "String" in PHP means binary, and operating
on multibyte
characters often causes problems.

Although I rarely deal with multibyte characters in my work, this can
probably be a big
problem for Japanese PHP users like myself.

To work around this, the mbstring extension must be used properly, but
since mbstring is
not built-in, it is appropriate to implement it in userland.

For the reasons stated above, we will abandon the addition of new methods.
sorry.

`str_shuffle()` and `shuffleString()` already have similar problems. So
perhaps an alternative
method name for `str_shuffle()` might be `bytesShuffle()` instead of
`stringShuffle()`.

Regards
Go Kudo

--0000000000007eff2805e1a90c22--