Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117990
MIME-Version: 1.0
References: <CAMs36Het5f=ojSw8H4kooZxub-COvhKmiJfYUUM7ioBSpVKFVA@mail.gmail.com>
 <CAMs36HewSTHNubys+Ss4rTbTWQE4vWyXL5OJLP8nMnrJ3GijKA@mail.gmail.com>
 <77a64074-875c-cfd6-5811-24b9d445f550@bastelstu.be> <CAMs36He2os0Fuw-qDTeMYkeuJQw-rqKmVm52-vb5j0drp5k6vA@mail.gmail.com>
 <3aac541e-b80d-1106-369f-a00a3a718f90@bastelstu.be>
In-Reply-To: <3aac541e-b80d-1106-369f-a00a3a718f90@bastelstu.be>
Date: Sat, 18 Jun 2022 02:46:24 +0900
Message-ID: <CAMs36Hdon9RHP+GOM=Rbkaie85Q4_LCnmqFmpLPOk9cthEYFoQ@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000e9115d05e1a855ae"
Subject: Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x
From: g-kudo@colopl.co.jp (Go Kudo)

--000000000000e9115d05e1a855ae
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B46=E6=9C=8818=E6=97=A5(=E5=9C=9F) 2:37 Tim D=C3=BCsterhus <tim@=
bastelstu.be>:

> Hi
>
> On 6/17/22 19:28, Go Kudo wrote
> >> I don't think that ->pickString() is a good name
> >
> > I see. But I think `randomString()` is ambiguous with `getBytes()`.
> >
> > `stringFromCharset(string $string, int $num): string` solves that, but =
I
> > think it is possible
> > that the meaning of "char" is not well known in the PHP world (although=
 I
> > think this name is most appropriate)
>
> ->stringFromAlphabet()?
>
> > How about adding an optional `?int $num` argument to
> `shuffleString(string
> > $string, ?int $num): string`?
> >
>
> No, because it would be pretty unclear what that `$num` argument would
> do there. It specifically would be different from the `$num` of
> `pickArrayKey()`. pickArrayKey() returns every key only once. Generating
> a string from a given charset may return the same character multiple
> times. Don't overload a single method with too many purposes.
>
> Best regards
> Tim D=C3=BCsterhus
>

I was fundamentally wrong, I understand now.
As you said, there was no interoperability with `pickArrayKey()` in the
first place...

> stringFromAlphabet()

Hmmm. I guess randomString would be better then. At the same time, it would
be nice to have an array version of randomArray.

However, I don't want to add more methods without any thought.
I think operations that can be done on userland should be done on userland.
That is why I did not implement the array_rand() function in the first
place.

I would like to hear other people's opinions in this area.
Incidentally, our own PHP implementation of the library (Xorshift128+) has
equivalents for arrayPickKey, stringPick, arrayPickValue, randomArray,
randomString. And it is useful.

Regards
Go Kudo

--000000000000e9115d05e1a855ae--