Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117989
Message-ID: <3aac541e-b80d-1106-369f-a00a3a718f90@bastelstu.be>
Date: Fri, 17 Jun 2022 19:37:35 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Go Kudo <g-kudo@colopl.co.jp>, internals@lists.php.net
References: <CAMs36Het5f=ojSw8H4kooZxub-COvhKmiJfYUUM7ioBSpVKFVA@mail.gmail.com>
 <CAMs36HewSTHNubys+Ss4rTbTWQE4vWyXL5OJLP8nMnrJ3GijKA@mail.gmail.com>
 <77a64074-875c-cfd6-5811-24b9d445f550@bastelstu.be>
 <CAMs36He2os0Fuw-qDTeMYkeuJQw-rqKmVm52-vb5j0drp5k6vA@mail.gmail.com>
In-Reply-To: <CAMs36He2os0Fuw-qDTeMYkeuJQw-rqKmVm52-vb5j0drp5k6vA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: [RFC] [VOTE] Random Extension 5.x
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 6/17/22 19:28, Go Kudo wrote
>> I don't think that ->pickString() is a good name
> 
> I see. But I think `randomString()` is ambiguous with `getBytes()`.
> 
> `stringFromCharset(string $string, int $num): string` solves that, but I
> think it is possible
> that the meaning of "char" is not well known in the PHP world (although I
> think this name is most appropriate)

->stringFromAlphabet()?

> How about adding an optional `?int $num` argument to `shuffleString(string
> $string, ?int $num): string`?
> 

No, because it would be pretty unclear what that `$num` argument would 
do there. It specifically would be different from the `$num` of 
`pickArrayKey()`. pickArrayKey() returns every key only once. Generating 
a string from a given charset may return the same character multiple 
times. Don't overload a single method with too many purposes.

Best regards
Tim Düsterhus