Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117946
Message-ID: <189243dc-de13-8b4b-3eaa-d41f9358a310@gmail.com>
Date: Tue, 14 Jun 2022 17:04:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-GB
To: internals@lists.php.net
References: <2b35605f-8da8-46b1-aec3-00bd1bfe47fd@www.fastmail.com>
 <2347345.PIDvDuAF1L@arnaud-t490>
 <8422e11c-4a3f-9f99-56ce-884491dfe08e@gmail.com>
 <2680037.BjyWNHgNrj@arnaud-t490>
In-Reply-To: <2680037.BjyWNHgNrj@arnaud-t490>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Short Closures 2, aka auto-capture take 3
From: rowan.collins@gmail.com (Rowan Tommins)

(Sorry for double reply, hit send too soon)

On 14/06/2022 12:18, Arnaud Le Blanc wrote:
> Your example uses isset(), which is valid code in most circumstances, but as
> you said it's not particularly good code. Do you have other examples that come
> to mind ?


There is plenty of code out there in the real world that is not 
particularly good, so I think it's a realistic example to think about.

The question is, do we think the language can and should help people 
avoid that mistake?

- Would the explicitness of "use(...)" make it more likely someone would 
spot it?
- Would people be more likely to write "let $guest=..." (or whatever 
block-scope keyword we choose) than add "$guest = null;" at the 
beginning of the closure?

I'm not totally sure, but we should always consider the impact on 
less-expert users, not just the power-users who are the ones often 
asking for new features.

Regards,

-- 
Rowan Tommins
[IMSoP]