Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117879
MIME-Version: 1.0
References: <CAH19jWht_1VBgZKWL8wfb5EL6oG8JQf1zxGN2nS7dswyVB9Pzg@mail.gmail.com>
 <CAH19jWhCnojDgXDbj+LAHnZk+ROPjmaAK2p1Q9f5TznR98bBTw@mail.gmail.com>
 <CAPzBOBPvz34-SefmFj3nTaAahqTqGmWm+i3z2VdAfe+FL9NTMw@mail.gmail.com>
 <CAESVnVrtQADCR6nUqHF-MmLdspuTH8ZE_B5fm1z_aFt7tMxryg@mail.gmail.com> <CAH19jWjXJbQmfEj8ai9DoFjoPGJrcSZv-t1nqrio4BjkGaZm4g@mail.gmail.com>
In-Reply-To: <CAH19jWjXJbQmfEj8ai9DoFjoPGJrcSZv-t1nqrio4BjkGaZm4g@mail.gmail.com>
Date: Wed, 8 Jun 2022 20:44:17 +0200
Message-ID: <CAAfnsFX4bceUk6ZPR63SW-Fa-r-R-+nZNeKGPNfM9BTXQYMX2g@mail.gmail.com>
To: shinji igarashi <sji@sj-i.dev>
Cc: Sara Golemon <pollita@php.net>, Robert Landers <landers.robert@gmail.com>, 
	internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000610c7705e0f418df"
Subject: Re: [PHP-DEV] Re: Adding new closing tag =?> for keeping trailing newline
From: petk@php.net (Peter Kokot)

--000000000000610c7705e0f418df
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 8 Jun 2022 at 20:16, shinji igarashi <sji@sj-i.dev> wrote:

> > declare(ignore_newline_after_close_tag=3Dfalse);
>
> Thanks for coming up with another idea!
>
> As others have already pointed out, disabling the closing tag from
> eating trailing newline throughout the file would be inconvenient if
> we want to use control statements in the template.
>
> However, we currently only have one closing tag, but we already
> have two opening tags. So, for example, if we use declare to disable
> the newline eating only when closing a PHP block started with `<?=3D',
> it can produce the desired output.
>
> <?php declare(ignore_newline_after_closing_short_tag=3Dfalse) ?>
> <?php foreach ([1, 2, 3] as $item): ?>
> - <? =3D $item ?>
> <?php endforeach ?>
>
> I'm honestly not sure if adding a declare switch is better received
> than a new closing tag, though.
>
> Thanks!
>
> --
> Shinji Igarashi
>
> 2022=E5=B9=B46=E6=9C=888=E6=97=A5(=E6=B0=B4) 12:34 Sara Golemon <pollita@=
php.net>:
> >
> > On Tue, Jun 7, 2022 at 10:27 AM Robert Landers <landers.robert@gmail.co=
m>
> wrote:
> > > FWIW, I think it makes a lot of sense, having used golang's template
> > > language (not everyone is generating HTML with PHP). I think you may
> > > just be dealing with a vocal minority and it would be worth putting t=
o
> > > an actual vote. Even if it fails, we'll learn something the next time
> > > someone wants to change something like this.
> > >
> >
> > While my gut response for the new end tag is in the "no" column, I do
> wonder if we can accommodate "non-html" scenarios in a broader (maybe mor=
e
> palatable?) way by assuming that if you want the newline to be respected =
on
> one line, you probably want it that way for the whole file.
> >
> > <?php
> > declare(ignore_newline_after_close_tag=3Dfalse); // defaults to true, i=
.e
> existing behavior
> >
> > This would avoid any new syntax rules, but still provide the ability fo=
r
> php-as-template-engine to behave in the user's preferred mode.
> >
> > -Sara
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php


I'm just adding a few cents into this discussion for some inspiration. If
I'm not mistaken, the Twig template engine, for example, has such a
difference integrated in the output tag and the statement tag. The
statement tag ({% %}) behaves as PHP tag, it removes the newline character.
The outputting tag ({{ }}) adds a newline at the end.

See this: https://twigfiddle.com/pto9qx

More info about this here:
https://twig.symfony.com/doc/3.x/templates.html#whitespace-control

So, it is actually important to have such functionality in templates.

--000000000000610c7705e0f418df--