Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117877
MIME-Version: 1.0
References: <CAH19jWht_1VBgZKWL8wfb5EL6oG8JQf1zxGN2nS7dswyVB9Pzg@mail.gmail.com>
 <CAH19jWhCnojDgXDbj+LAHnZk+ROPjmaAK2p1Q9f5TznR98bBTw@mail.gmail.com> <CAPzBOBPvz34-SefmFj3nTaAahqTqGmWm+i3z2VdAfe+FL9NTMw@mail.gmail.com>
In-Reply-To: <CAPzBOBPvz34-SefmFj3nTaAahqTqGmWm+i3z2VdAfe+FL9NTMw@mail.gmail.com>
Date: Thu, 9 Jun 2022 02:50:45 +0900
Message-ID: <CAH19jWioc0oeCywRkTWTC3dFMyaK1uwHvUZD69Oa1dnrAwzP_A@mail.gmail.com>
To: Robert Landers <landers.robert@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: Adding new closing tag =?> for keeping trailing newline
From: sji@sj-i.dev (shinji igarashi)

Hello!

> I think you may just be dealing with a vocal minority and it would be wor=
th putting to
> an actual vote. Even if it fails, we'll learn something the next time
> someone wants to change something like this.

Thanks for the feedback!

In my experience over the years of watching internals, many
controversial language changes do not survive the voting. Two
Yeses are balanced against one No, so there needs to be
overwhelming agreement.

Surely it could at least be said that even if it fails, it is easier for
someone who later comes up with a similar idea to find past efforts
if the RFC is drafted and the results of the voting are there.

However, the July 19 Feature Freeze for 8.2 is approaching!
So I'll try to write an RFC on this proposal later for 8.3.

For now, I will look at the interpreter code and see if I can come up
with another proposal and its implementation that is a little less
controversial (like constants on traits) until the 8.2 effective deadlines.

My ability to write English is very limited, so probably I cannot
proceed with multiple proposals in parallel.

Thanks!

--
Shinji Igarashi

2022=E5=B9=B46=E6=9C=888=E6=97=A5(=E6=B0=B4) 0:27 Robert Landers <landers.r=
obert@gmail.com>:
>
> On Mon, Jun 6, 2022 at 6:47 PM shinji igarashi
> <shinji.igarashi@gmail.com> wrote:
> >
> > Hello!
> >
> > I asked for opinions on reddit also.
> > https://www.reddit.com/r/PHP/comments/v5le6h/adding_new_closing_tag_for=
_keeping_trailing/
> >
> > Popularity on reddit and acceptance by people with voting rights on
> > internals can be different, but it seems that, at least in its current
> > form, this proposal would have a hard time winning the vote.
> >
> > Until I can come up with a stronger persuasion or a nicer way of
> > doing this, I don't feel it has a chance to win, so I'm withdrawing
> > from this proposal for now and going to work on something else.
> >
> > Thanks for taking a look!
> >
> > --
> > Shinji Igarashi
> >
> > 2022=E5=B9=B46=E6=9C=885=E6=97=A5(=E6=97=A5) 17:23 shinji igarashi <sji=
@sj-i.dev>:
> > >
> > > Hello everyone,
> > >
> > > I'd like to propose adding a new closing tag `=3D?>` to the language.
> > >
> > > PHP currently removes the newline character immediately following
> > > the closing tag `?>`.
> > >
> > > With the new closing tag `=3D?>`,  the code should look like this:
> > >
> > > ```
> > > - <?=3D 1 =3D?>
> > > - <?=3D 2 =3D?>
> > > - <?=3D 3 =3D?>
> > > ```
> > >
> > > and the results it produces would be:
> > >
> > > ```
> > > - 1
> > > - 2
> > > - 3
> > > ```
> > >
> > > instead of the following:
> > >
> > > ```
> > > - 1- 2- 3
> > > ```
> > >
> > > This addition requires only a one-line modification to the lexer and
> > > doesn't break BC. The proposed patch is here.
> > > https://github.com/php/php-src/pull/8708
> > >
> > > Before writing an RFC, I would like to hear your input on whether
> > > it's worth tackling.
> > >
> > > Thanks!
> > >
> > > --
> > > Shinji Igarashi
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: https://www.php.net/unsub.php
> >
>
> FWIW, I think it makes a lot of sense, having used golang's template
> language (not everyone is generating HTML with PHP). I think you may
> just be dealing with a vocal minority and it would be worth putting to
> an actual vote. Even if it fails, we'll learn something the next time
> someone wants to change something like this.