Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117863
MIME-Version: 1.0
References: <CAMs36Hdq7Bh+fj62NBY7L5RSMy-4OOncs3fKzUQu9GzUf-zMWw@mail.gmail.com>
 <1661CAFC-5CC9-4F70-AE58-F36B46B5CC92@chilliet.eu>
In-Reply-To: <1661CAFC-5CC9-4F70-AE58-F36B46B5CC92@chilliet.eu>
Date: Tue, 7 Jun 2022 20:03:49 +0900
Message-ID: <CAMs36HdOkN1uRysodKoQJPNAA7FuQXru3Dt9ma+S=G5XDOVAMw@mail.gmail.com>
To: =?UTF-8?Q?C=C3=B4me_Chilliet?= <come@chilliet.eu>, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000ba404d05e0d98bc0"
Subject: Re: [PHP-DEV] [RFC] [Vote] Pre-vote announcement for Random Extension 5.x
From: g-kudo@colopl.co.jp (Go Kudo)

--000000000000ba404d05e0d98bc0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B46=E6=9C=884=E6=97=A5(=E5=9C=9F) 18:03 C=C3=B4me Chilliet <come=
@chilliet.eu>:

> Le 31 mai 2022 11:54:18 GMT+02:00, Go Kudo <g-kudo@colopl.co.jp> a =C3=A9=
crit :
> >Hi internals.
> >
> >Although I have explained that due to the global turmoil I will delay
> >voting on the RFC as long as possible, it is time to start voting on the
> >RFC in order to get the implementation to full status by the PHP 8.2
> >Feature Freeze.
> >
> >I apologize for the delay in responding to the points you had already
> >pointed out. It has been addressed as follows.
> >
> >- Random\Engine\PCG64::__construct() now takes an `int|string` $inc as i=
ts
> >second argument
> >    - This makes it fully compatible with the PCG64 original
> implementation
> >- Fixed an algorithm implementation error in PCG64
> >- Fixed compatibility issues with PHP 8.2 in test cases
> >- More detailed description in RFC
> >
> >Previous discussion thread: https://externals.io/message/117295
> >
> >Voting will begin at 2022-06-14 00:00:00 (UTC).
> >
> >https://wiki.php.net/rfc/rng_extension
> >
> >Regards,
> >Go Kudo
>
> The first section starts with "However", which sounds like an error from =
a
> text reorganization?
> Also:
> "adding any randomization functions between the seeding the intended usag=
e
> would break the code. " -> missing "and" I suppose
> "Even with JIT enabled, the native implementation is not far behind. " ->
> it *is* far behind no? It's not even behind but ahead as I see it so mayb=
e
> I just misunderstand this comment.
>
> C=C3=B4me
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

> The first section starts with "However", which sounds like an error from
a text reorganization?
> "adding any randomization functions between the seeding the intended
usage would break the code. " -> missing "and" I suppose

Thanks, I fixed it.

> "Even with JIT enabled, the native implementation is not far behind. " ->
it *is* far behind no? It's not even behind but ahead as I see it so maybe
I just misunderstand this comment.

Just wanted to explain that the native implementation is faster. (C > PHP)
I changed it to a more clear form.

(I was replying directly to you. sorry)

--000000000000ba404d05e0d98bc0--