Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117856
MIME-Version: 1.0
References: <CAH19jWht_1VBgZKWL8wfb5EL6oG8JQf1zxGN2nS7dswyVB9Pzg@mail.gmail.com>
 <CA+p1FaYn9EKNDzwSA82Wyjfc4yVw6ZSdSrX2_jWGVaBnGt=hpw@mail.gmail.com>
In-Reply-To: <CA+p1FaYn9EKNDzwSA82Wyjfc4yVw6ZSdSrX2_jWGVaBnGt=hpw@mail.gmail.com>
Date: Mon, 6 Jun 2022 07:36:03 +0900
Message-ID: <CAH19jWjR6Pd3PJgQJoqm5-0c3x0+YjfD+_a-zeV_inHJDtEKSQ@mail.gmail.com>
To: David Gebler <davidgebler@gmail.com>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Adding new closing tag =?> for keeping trailing newline
From: sji@sj-i.dev (shinji igarashi)

>  <?=3D $whatever . PHP_EOL ?> or ."\n"
Yeah, adding an explicit newline character is a workaround for this.

However, what if that output content were moved to a location other
than the end of a line when editing the template? It would be
necessary to remove the extra newline character each time
they move from the end of a line.
With this new closing tag, the behavior of the output block can be
position-independent.

Your concerns are valid and I agree that this is a small difference.
What I am not sure about is how many people want this small
difference, so I'm asking around in some parts of the community.

Thanks for your feedback!

--
Shinji Igarashi

2022=E5=B9=B46=E6=9C=886=E6=97=A5(=E6=9C=88) 6:31 David Gebler <davidgebler=
@gmail.com>:
>
> On Sun, Jun 5, 2022 at 9:24 AM shinji igarashi <sji@sj-i.dev> wrote:
>>
>> Hello everyone,
>>
>> I'd like to propose adding a new closing tag `=3D?>` to the language.
>>
>> PHP currently removes the newline character immediately following
>> the closing tag `?>`.
>
>
> Personal opinion, seems like a classic sledgehammer on a nut proposal. I =
actually prefer the <?=3D $whatever . PHP_EOL ?> or ."\n" notation since it=
 makes it explicitly clear what you're intending to output and keeps it wit=
hin the control of the PHP code block. Alternatively it's also enough in th=
e case of plain text or wherever else this matters to you to just add a spa=
ce after the closing tag before the newline (granted there may be niche sit=
uations where this is undesirable).
>
> It's not a breaking change for any existing code, at least, but for me I =
still don't see enough of a benefit that I'd think it was worth adding to t=
he language, as any new syntax creates the potential for confusion and user=
 error. Is this a big enough problem to be worth any change at all? In over=
 15 years of writing PHP, I've never once had a situation where closing tag=
 newline elision has been an issue.
>
> -Dave
>
>>
>>
>> With the new closing tag `=3D?>`,  the code should look like this:
>>
>> ```
>> - <?=3D 1 =3D?>
>> - <?=3D 2 =3D?>
>> - <?=3D 3 =3D?>
>> ```
>>
>> and the results it produces would be:
>>
>> ```
>> - 1
>> - 2
>> - 3
>> ```
>>
>> instead of the following:
>>
>> ```
>> - 1- 2- 3
>> ```
>>
>> This addition requires only a one-line modification to the lexer and
>> doesn't break BC. The proposed patch is here.
>> https://github.com/php/php-src/pull/8708
>>
>> Before writing an RFC, I would like to hear your input on whether
>> it's worth tackling.
>>
>> Thanks!
>>
>> --
>> Shinji Igarashi
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: https://www.php.net/unsub.php
>>