Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117851
Date: Sat, 04 Jun 2022 11:02:50 +0200
To: internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <CAMs36Hdq7Bh+fj62NBY7L5RSMy-4OOncs3fKzUQu9GzUf-zMWw@mail.gmail.com>
References: <CAMs36Hdq7Bh+fj62NBY7L5RSMy-4OOncs3fKzUQu9GzUf-zMWw@mail.gmail.com>
Message-ID: <1661CAFC-5CC9-4F70-AE58-F36B46B5CC92@chilliet.eu>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: =?US-ASCII?Q?Re=3A_=5BPHP-DEV=5D_=5BRFC=5D_=5BVote=5D_Pre-vote_?= =?US-ASCII?Q?announcement_for_Random_Extension_5=2Ex?=
From: come@chilliet.eu (=?ISO-8859-1?Q?C=F4me_Chilliet?=)

Le 31 mai 2022 11:54:18 GMT+02:00, Go Kudo <g-kudo@colopl=2Eco=2Ejp> a =C3=
=A9crit=C2=A0:
>Hi internals=2E
>
>Although I have explained that due to the global turmoil I will delay
>voting on the RFC as long as possible, it is time to start voting on the
>RFC in order to get the implementation to full status by the PHP 8=2E2
>Feature Freeze=2E
>
>I apologize for the delay in responding to the points you had already
>pointed out=2E It has been addressed as follows=2E
>
>- Random\Engine\PCG64::__construct() now takes an `int|string` $inc as it=
s
>second argument
>    - This makes it fully compatible with the PCG64 original implementati=
on
>- Fixed an algorithm implementation error in PCG64
>- Fixed compatibility issues with PHP 8=2E2 in test cases
>- More detailed description in RFC
>
>Previous discussion thread: https://externals=2Eio/message/117295
>
>Voting will begin at 2022-06-14 00:00:00 (UTC)=2E
>
>https://wiki=2Ephp=2Enet/rfc/rng_extension
>
>Regards,
>Go Kudo

The first section starts with "However", which sounds like an error from a=
 text reorganization?
Also:
"adding any randomization functions between the seeding the intended usage=
 would break the code=2E " -> missing "and" I suppose
"Even with JIT enabled, the native implementation is not far behind=2E " -=
> it *is* far behind no? It's not even behind but ahead as I see it so mayb=
e I just misunderstand this comment=2E

C=C3=B4me