Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117709
Date: Mon, 09 May 2022 18:20:02 -0700 (PDT)
To: <internals@lists.php.net>
Message-ID: <656B3B10-E159-4696-A814-76A2D4CB250F@automattic.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="=_B3CA2235-981F-4773-AD6A-FD0852070ACA"
Subject: Re: [PHP-DEV] [RFC] Exposed parsed value of php.ini numeric directives
From: dennis.snell@automattic.com (Dennis Snell)

--=_B3CA2235-981F-4773-AD6A-FD0852070ACA
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable

>=C2=A0`ini_get_size($option)` would be nice to have, but may not be feasib=
le,
see <https://github.com/php/php-src/pull/8380#issuecomment-1100226598
>.


I concur and did start by exploring this idea. It raised too many questions=
 when a simpler interface seemed
to accomplish what we need in practice.


> I guess it could [have ]be[en] useful to Symfony too:


It's my presumption that many projects have had to build some workaround, m=
ost of which are defective in a
range of plausible values (such as the linked Symphony code that interprets=
 a `t` when PHP doesn't). Adding
this scope-limited function could be dramatic in removing the need to port =
PHP internals to outside projects.


>=C2=A0Regarding the name: What about 'ini_get_as_bytes()'? It makes the=
=C2=A0
relationship with 'ini_get()' clear by using the same prefix and the=C2=A0
suffix should be reasonable explanatory in what happens.

> Just not sure whether it should be e.g. `ini_get_size($option)` (like
ini_get) or rather e.g. `ini_parse_size($value)` (more generally
usable).


Given that many non-memory-size configuration settings also currently use t=
his same parsing flow I have been
mixed on associating this with "byte sizes" the way the PHP docs indicate. =
In fact, based on the work in #7951
I've renamed my proposed function to `ini_parse_quantity( $shorthand )` and=
 rather like the match between
the implementation and meaning.



---


Dennis Snell






--=_B3CA2235-981F-4773-AD6A-FD0852070ACA--