Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117634
MIME-Version: 1.0
References: <3fcdfa2c-7a9c-d634-ea56-8b1e5bf1a911@gmx.net> <C7ADCE20-81E1-4F7C-B0B7-1D32173A3E5B@cschneid.com>
 <bcec65a6-8c71-a66b-f834-81cbf12794f9@gmail.com> <5ceeb3f0-0f01-8b93-00ca-9947c9c69e4c@gmx.net>
 <73775976-c23d-0ee1-3ea2-ffb39431fc50@gmail.com>
In-Reply-To: <73775976-c23d-0ee1-3ea2-ffb39431fc50@gmail.com>
Date: Wed, 27 Apr 2022 13:30:31 +0200
Message-ID: <CAC5V6gjyRKCbyaBo+oqaBb78TF25Gu1XLYtSSMVubaqd0V62Pw@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000a0afee05dda1234c"
Subject: Re: [PHP-DEV] Stricter implicit boolean coercions
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--000000000000a0afee05dda1234c
Content-Type: text/plain; charset="UTF-8"

> > 'on' is only true by "accident" though, because it is a non-empty
> > string, not because of its meaning, and then it is likely that the value
> > 'off' could also be added at some point - which also would be true.
>
> The reason I gave that particular example is that it's the default
> submission value for an HTML checkbox when checked; if it's not checked,
> it has no value at all (not even an empty string), so in that particular
> context there is no corresponding "off".
>

That's why you must test it with isset($_POST['checkbox_name']), *not* with
(bool)$_POST['checkbox_name'] or an implicit conversion.

if ( $nullable_float = type_coerce_or_return_default('?float', $var,
> false) === false ) { throw new TypeError; }
>

Missing parentheses around the assignment (VS the comparison)!


Only allowing the following values would make sense
> from my perspective:
>
> '1' => true
> 1 => true
> 1.0 => true
> '' => false
> '0' => false
> 0 => false
> 0.0 => false
>

Seems a reasonable compromise (between BC and bugs-protection).

Regards,

-- 
Guilliam Xavier

--000000000000a0afee05dda1234c--