Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117619
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Date: Tue, 26 Apr 2022 17:01:19 +0200
References: <3fcdfa2c-7a9c-d634-ea56-8b1e5bf1a911@gmx.net>
 <C7ADCE20-81E1-4F7C-B0B7-1D32173A3E5B@cschneid.com>
 <08ddcfdf-54a8-6f6d-979b-7d819a882f4e@gmx.net>
To: PHP Developers Mailing List <internals@lists.php.net>
In-Reply-To: <08ddcfdf-54a8-6f6d-979b-7d819a882f4e@gmx.net>
Message-ID: <1DD783DC-236A-40F2-987A-5F483A68E0D4@cschneid.com>
Subject: Re: [PHP-DEV] Stricter implicit boolean coercions
From: cschneid@cschneid.com (Christian Schneider)

Am 26.04.2022 um 15:16 schrieb Andreas Leathley <a.leathley@gmx.net>:
> On 26.04.22 14:47, Christian Schneider wrote:
>> There are two big reasons:
>> - BC: Checking for the truthiness of a value is very common and would =
require a lot of code changes.
>> - Some of us like the conciseness of "if ($foo) ...", see below
>=20
> That would not be my target - in an if expression a lot more values =
are
> allowed anyway (arrays, objects, etc.), so this is not about =
determining
> truthiness, but actual conversions to a bool type, like a bool
> parameter, a bool return type or a bool property type.

I see, so as long as there are no bool type hints for function =
parameters everything would be the same.

This would lead to a minor asymmetry for
	$preserve =3D "yes";
	if ($preserve)	# Silently working, true
		array_slice($array, $offset, preserve_keys: $preserve));	=
# Not working any more

I assume your solution would be to add an explicit cast to bool? i.e. =
something along the lines of
		array_slice($array, $offset, preserve_keys: =
(bool)$preserve));	# Explicit cast to silence implicit conversion

I'm a bit worried about having to keep two different convert-to-bool =
rule sets in mind (implicit vs. explicit) and about the additional =
casts.

Regards,
- Chris