Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117480
MIME-Version: 1.0
References: <CAFPFaM+pJTUQYdiBiL134HK38eQrskE_yCrC_etrk3UXVGhoKg@mail.gmail.com>
 <CADyq6s+2H0CXqVVTC3vacwoZmRGiOgo7o0X7Kc+AZtp=mVa+Uw@mail.gmail.com>
In-Reply-To: <CADyq6s+2H0CXqVVTC3vacwoZmRGiOgo7o0X7Kc+AZtp=mVa+Uw@mail.gmail.com>
Date: Wed, 6 Apr 2022 13:36:12 +0200
Message-ID: <CAC5V6gg6LrpW1tw3976zfUn0rWkJda_e_S-DFOyXt8ioORNdVA@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000077ce7205dbfac56d"
Subject: Re: [PHP-DEV] Reflection changes due to allow null + false as
 standalone types RFC
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--00000000000077ce7205dbfac56d
Content-Type: text/plain; charset="UTF-8"

Hi George,

> https://github.com/php/php-src/pull/7546#discussion_r837900447

Thanks for asking (even if voted).

On Tue, Apr 5, 2022 at 2:01 PM Marco Pivetta <ocramius@gmail.com> wrote:

> Probably best with consistency?
>
>  > - Ignore the Reflection changes of the RFC and align the union type with
> the current behaviour
>
> This one, specifically.
>

I agree with Marco (who I know works on reflection-related projects).

To expand a bit:

when reading the RFC, "the notable exception that `null|false` will produce
a ReflectionUnionType instead of a ReflectionNamedType contrary to other
`null|T` types" seemed legit because
  - `T|false` currently always produces a ReflectionUnionType
  - `null|T` producing a ReflectionNamedType (like `?T`) was only decided
*for backwards-compatibility reasons* [
https://wiki.php.net/rfc/union_types_v2#reflection]
(moreover the initial RFC [https://wiki.php.net/rfc/null-standalone-type]
only proposed standalone `null`, not `false`, so didn't allow `?false`)

but now looking at the implementation, I don't like the special casing.

Regards,

-- 
Guilliam Xavier

--00000000000077ce7205dbfac56d--