Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117467
User-Agent: Cyrus-JMAP/3.7.0-alpha0-382-g88b93171a9-fm-20220330.001-g88b93171
Mime-Version: 1.0
Message-ID: <a49138b4-48de-40d3-85c5-fdc0db313c4e@www.fastmail.com>
In-Reply-To: 
 <CAPyj-LBysaB2+jDN9u08T61mEj+ZL3Jd7XEbi==mphjQc2Gn=Q@mail.gmail.com>
References: 
 <CAPyj-LBysaB2+jDN9u08T61mEj+ZL3Jd7XEbi==mphjQc2Gn=Q@mail.gmail.com>
Date: Thu, 31 Mar 2022 10:50:09 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] Add leading backslash to enum and class names in var_export
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Mar 31, 2022, at 10:45 AM, Ilija Tovilo wrote:
> Hi everyone
>
> We've had two bug reports for var_export not working for enums. The
> reason for that is that var_export does not add a leading backslash to
> names of enums. This will cause them to be resolved as
> `\CurrentNamespace\EnumNamespace\EnumName` instead of just
> `\EnumNamespace\EnumName`.
>
> enum A {
>     case B;
> }
>
> echo var_export(A::B, true), "\n";
>> A::B
>
>
> This is a problem for things like Doctrines ProxyGenerator that embeds
> the result of var_export in classes with namespaces
> (https://github.com/doctrine/common/pull/955). The Doctrine team
> resolved this by adding a `use` of the enum at the top of the file but
> that really shouldn't be necessary.
>
> The same issue already exists for classes.
>
> class C {}
>
> echo var_export(new C(), true), "\n";
>> C::__set_state(array(
>> ))
>
> https://bugs.php.net/bug.php?id=64554
>
> Marco Pivetta created a PR that adds leading backslash to all class or
> enum names of var_export. Adding a backslash will make the code work
> both inside or outside namespaces.
> https://github.com/php/php-src/pull/8233
>
> To avoid disruption, I'm proposing to merge this into PHP 8.2 only.
> Unless anybody has any objections to this change I will merge it in a
> few weeks.
>
> Ilija

What would be the disruption on 8.1?  It wouldn't break the existing `use` trick, and I doubt anyone is leveraging this deliberately.

--Larry Garfield