Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117434
Message-ID: <be2b9f28-7999-e78b-8e18-c80565dbcb73@gmail.com>
Date: Sat, 26 Mar 2022 22:22:44 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-GB
To: internals@lists.php.net
References: <22242169-a16d-5261-696c-3cf00b00336a@gmail.com>
 <0b322a3e-469a-7ed7-16e3-0b76287f4091@gmail.com>
 <623BAFB6.4000901@adviesenzo.nl>
 <e1d7e5d9-cfa0-f036-0d5b-b9a2defb8c53@gmail.com>
 <19112CBA-7BA7-4AA8-95BF-76EE20ECE56C@cschneid.com>
 <d4853f34-c15c-5a2e-299d-d1bffe382a8f@gmail.com>
In-Reply-To: <d4853f34-c15c-5a2e-299d-d1bffe382a8f@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Deprecate and Remove utf8_encode and utf8_decode
From: rowan.collins@gmail.com (Rowan Tommins)

On 24/03/2022 11:19, Rowan Tommins wrote:
>> I have one issue with the wording in the RFC: While “Function 
>> utf8_encode is deprecated; check usage is correct and consider 
>> mb_convert_encoding or other replacement.” suggests to replace it, 
>> the part about checking the usage implies that if someone is sure 
>> about the correct usage it is fine to keep using utf8_encode(). But 
>> as the proposal wants to remove it for 9.0 I think this is somewhat 
>> misleading.
>
>
> That's a fair point. The intention was to encourage people to look at 
> whether they were using the function right in the first place, not 
> blindly replace it with mb_convert_encoding, since the whole point of 
> the deprecation is that they probably aren't. I'm not sure how to 
> concisely say "replace with mb_convert_encoding if you actually need 
> to, but maybe you can just delete this function call and your code 
> will be better".


Maybe I'm trying to be "too helpful" there. Should we just use the 
generic deprecation message, and let people look up the in-depth 
explanation in the manual?

Anyone have any thoughts on that?

Regards,

-- 
Rowan Tommins
[IMSoP]