Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117304
Message-ID: <f5a3cbe6-60b0-00ff-8be2-efc95d85d9a1@gmail.com>
Date: Fri, 11 Mar 2022 19:50:11 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CAPyj-LDVVfrSx1B3DpW+VjOe78twZVbPsGRv+k96MJ=1A3vCAw@mail.gmail.com>
In-Reply-To: <CAPyj-LDVVfrSx1B3DpW+VjOe78twZVbPsGRv+k96MJ=1A3vCAw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC][Under discussion] Deprecate ${} string
 interpolation
From: rowan.collins@gmail.com (Rowan Tommins)

On 11/03/2022 17:13, Ilija Tovilo wrote:
> https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation


Hi Ilija,

Thanks for progressing with this, and making a clear case why these 
syntaxes are confusing and redundant.

I presume the intent here is that the engine will generate an 
E_DEPRECATED each time such a string is encountered. Do you know yet if 
that will be easy to implement? I think some simple string handling is 
built into the parser, so there may not be a single code path to look at.

The other question which I'm sure lots of users will have when they see 
the deprecation is: How easy is it to adapt usages of the deprecated 
syntax to use the non-deprecated variants? I'm guessing it's not as 
simple as moving the $ sign, because as you point out the syntaxes have 
different semantics; is there a general rule that users and/or tools can 
use to generate correct replacements?

A final thought is that I seem to remember a previous thread (from 
Nikita?) about the "$foo[bar]" syntax, which is also confusing. Maybe we 
should consider deprecating that at the same time?

Overall, I'm definitely in favour of this simplification.

Regards,

-- 
Rowan Tommins
[IMSoP]