Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117250
MIME-Version: 1.0
References: <CA+_wxSRxVKoPEJbiV4OPuMufm3brT-ueQdvxEFLKSdTMjBa-Jg@mail.gmail.com>
 <f45c3b9f-6973-4ecb-99c7-1129fa9d51c2@www.fastmail.com> <CA+_wxSTejQ7o5+KXb5uOyb7aNpfxNu==K7YMXGE+Uv4eSV0npA@mail.gmail.com>
In-Reply-To: <CA+_wxSTejQ7o5+KXb5uOyb7aNpfxNu==K7YMXGE+Uv4eSV0npA@mail.gmail.com>
Date: Thu, 3 Mar 2022 19:31:16 +0100
Message-ID: <CAB-Bujb5P+EQjBohCLpOhhUssjw-ghqco3zVn6D2x8R6tdzPeg@mail.gmail.com>
To: DANIEL VARGAS MUCCILLO <daniel.muccillo@ufsm.br>
Cc: Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Interface for reflection entities who implements
 getAttributes method
From: andreas@dqxtech.net (Andreas Hennings)

On Tue, 1 Mar 2022 at 21:03, DANIEL VARGAS MUCCILLO
<daniel.muccillo@ufsm.br> wrote:
>
> >
> >  I *think* all Reflector children support attributes, so it may not need a
> > separate interface.
>
>
> ReflectionZendExtension and ReflectionExtension are currently the only ones
> who implement Reflector but don't support attributes.

There is also ReflectionAttribute itself which does not have getAttributes().

>
>
> > However, the entire Reflection class hierarchy is a mess and needs a
> > number of additional interfaces added to it generally.  It makes sense to
> > overhaul it holistically to make sure it all fits together.
> >
>
> Was not aware of other cases, but a quick look led to:
>
>    - getExecutingFile() : string and getExecutingLine() : int in
>    ReflectionFiber and ReflectionGenerator;
>    - getDocComment() : string|false in ReflectionClass,
>    ReflectionClassConstant, ReflectionFunctionAbastract and ReflectionProperty;
>    - getName(), getNameSpaceName() and getModifiers() in some cases (not
>    always together).
>
> Should it be the case to expand the scope to handle these in the same
> proposal or maybe create a Meta RFC and discuss each on their own?
>
>
> > I have zero availability until mid-March, but I'm open to helping at that
> > point.
>
>
> Thanks for your return on that, I'll try to run at least a little on my own
> foot until there, so I can be less of a burden!
>
> --
> Daniel Vargas Muccillo