Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117180
MIME-Version: 1.0
References: <CAFv4g+Efz-V5V1uUedXpusNw6z-on=TT3kdWgC66SptSd8kB4g@mail.gmail.com>
 <CAFv4g+GDsq=w7qtSOVptEBiTTDZk2aeFCVGThVBR=0-xk=0oAA@mail.gmail.com>
 <983552d8-11f1-b5bc-fb82-148347982fda@gmx.de> <5494eaa7-2fa6-8364-9683-a2c8c9789d81@gmail.com>
 <CAC5V6gjianVuPo654_-mETYxsu0-eSo++Ez1yy81MNEcfwFq1Q@mail.gmail.com>
 <69642616-72b7-44fe-97a7-27ae03bc8fce@www.fastmail.com> <CAFv4g+F0HOgCgeUyiG06qhxQnWbVCN2aaP=a2CJT9tkbMP7kLg@mail.gmail.com>
 <7fbed755-42e2-d023-285f-39863a97f297@gmx.de> <3665C848-B4C3-4528-AEFA-02C868748AA8@cschneid.com>
 <0b5bc29d-3814-0e1d-b94a-47790019c778@gmx.de> <5463E9FF-309D-4CFA-B709-81498B934059@cschneid.com>
In-Reply-To: <5463E9FF-309D-4CFA-B709-81498B934059@cschneid.com>
Date: Tue, 1 Mar 2022 16:28:58 +0000
Message-ID: <CAFv4g+ExKL=g-Jx=xs9c1SGVQkavDStHn7NHrkvJSHbwLLnjcA@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001aef0805d92aaa90"
Subject: Re: [PHP-DEV] Allowing NULL for some internal functions
From: craig@craigfrancis.co.uk (Craig Francis)

--0000000000001aef0805d92aaa90
Content-Type: text/plain; charset="UTF-8"

On Tue, 1 Mar 2022 at 13:06, Christian Schneider <cschneid@cschneid.com>
wrote:

> The other way of making internal functions behave like user land functions
> would be to change the definition of the internal function to
>         function htmlentities(?string $value) { ... }
> and casting it to string internally which would make the
> definition/documentation/behavior consistent while staying backward
> compatible.
>


True, that is an option, and that's where I started... but I changed my
mind, because developers who use `strict_types=1` can use this extra meta
data (the type check) to verify their code is working as expected.

In other words, someone checking types can see NULL being passed to
functions like escapeshellarg() as an error, and I do not want to break
that for them.

Craig

--0000000000001aef0805d92aaa90--