Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:117162 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 99590 invoked from network); 28 Feb 2022 14:16:25 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 28 Feb 2022 14:16:25 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 8C5091804D9 for ; Mon, 28 Feb 2022 07:37:25 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS199118 195.10.208.0/24 X-Spam-Virus: No X-Envelope-From: Received: from mout-b-206.mailbox.org (mout-b-206.mailbox.org [195.10.208.51]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 28 Feb 2022 07:37:24 -0800 (PST) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-b-206.mailbox.org (Postfix) with ESMTPS id 4K6kyq1Scpz9sbF for ; Mon, 28 Feb 2022 16:37:23 +0100 (CET) Message-ID: <56e50b35-d854-b619-82a9-36eab0149190@woltlab.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=woltlab.com; s=MBO0001; t=1646062641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mu7u9ctiiZ0ibxtAc6aHX/tIj/cQ/j7DX4X1ESc93ic=; b=ytJzOeP+um/bQJIi8+op7si3mmXCSXTxNGZB5RlLYn7TNk2AIGGP89C4U545+6LsXMhzhd TkumR3pk8yLnrTr/nizHeWgpNxzKmwO/AjxudlSdr1SHWWKHpHQZ0d10zpKwwd5i4epFgD 0+XcCNsxfBUDBCjFAIAP/DQkmCXJ1mcRyQzna4dr0Gk2uPockXsmCzAUttEmdlD6URFeRJ kfUOQ56vY/mAHlA99FeywLgX4tD0BWC03mb1+wj4FitLYQUnf6CW8lmxoF8Orlx1QqDEGR kiwO0Y84GUPFSqNOTPLIebJDpT6YghCu2DXKNX+Z1V7fA4pnLiubBMAsXE2DNQ== Date: Mon, 28 Feb 2022 16:37:14 +0100 MIME-Version: 1.0 Content-Language: en-US To: PHP internals References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] SensitiveParameterValue serialization behavior From: duesterhus@woltlab.com (=?UTF-8?Q?Tim_D=c3=bcsterhus=2c_WoltLab_GmbH?=) Hi Internals! On 2/24/22 15:11, Tim Düsterhus, WoltLab GmbH wrote: > Please find the thread in the GitHub PR at: > > https://github.com/php/php-src/pull/7921#discussion_r813743903 > > […] > > 1. Disallow both serialization and unserialization. > > This will make the serialization issue very obvious, but will require > adjustments to exception handlers that serialize the stack traces. Thank you for voicing your opinion. I've adjusted the implementation to "Disallow both serialization and unserialization": https://github.com/php/php-src/pull/7921#discussion_r815976815 As per Dan's response disallowing serialization is the "safe" choice with regard to future changes and it neatly avoids the bikeshedding with regard to the exception class to use [1]. I'll make sure to update the RFC with an errata section later. [1] https://externals.io/message/117022#117120 Best regards Tim Düsterhus Developer WoltLab GmbH -- WoltLab GmbH Nedlitzer Str. 27B 14469 Potsdam Tel.: +49 331 96784338 duesterhus@woltlab.com www.woltlab.com Managing director: Marcel Werk AG Potsdam HRB 26795 P