Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117153
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4778-g14fba9972e-fm-20220217.001-g14fba997
Mime-Version: 1.0
Message-ID: <f45c3b9f-6973-4ecb-99c7-1129fa9d51c2@www.fastmail.com>
In-Reply-To: 
 <CA+_wxSRxVKoPEJbiV4OPuMufm3brT-ueQdvxEFLKSdTMjBa-Jg@mail.gmail.com>
References: 
 <CA+_wxSRxVKoPEJbiV4OPuMufm3brT-ueQdvxEFLKSdTMjBa-Jg@mail.gmail.com>
Date: Sun, 27 Feb 2022 09:21:43 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] Interface for reflection entities who implements getAttributes
 method
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, Feb 25, 2022, at 4:57 PM, DANIEL VARGAS MUCCILLO wrote:
> Hi Internals, hope you are all well.
>
> I've been playing around with Attributes and found that the only
> way for safely type hint for reflection entities who implement the
> getAttributes method is the following union:
>
> ReflectionClass|ReflectionClassConstant|ReflectionFunctionAbstract|ReflectionParameter|ReflectionProperty
>> $reflectionEntity
>
>
> For a single use case this was ok, but i would like to survey if
> people here would be interested in the introduction of a interface
> against which we could correctly ensure, with less effort, that
> getAttribute is available.
>
> I believe that it would be something along the lines of:
>
>> interface AttributeReflector {
>
>     public function getAttributes(?string $name = null, int $flags = 0):
>> array;
>
> }
>
>
> I have no experience with the PHP's source code, but if you think
> that it's a good idea I would like to propose an RFC along with a PoC
> patch to make this adition.
>
> Thanks for your time until now and all the good work I've seen here.
>
> -- 
> Daniel Vargas Muccillo

I've run into this problem as well.  I *think* all Reflector children support attributes, so it may not need a separate interface.  However, the entire Reflection class hierarchy is a mess and needs a number of additional interfaces added to it generally.  It makes sense to overhaul it holistically to make sure it all fits together.

I have zero availability until mid-March, but I'm open to helping at that point.

--Larry Garfield