Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:117134 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 29189 invoked from network); 24 Feb 2022 07:49:53 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Feb 2022 07:49:53 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id BC7B2180381 for ; Thu, 24 Feb 2022 01:09:49 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS8412 83.65.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from mail02.x-net.at (mail02.x-net.at [83.65.141.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Thu, 24 Feb 2022 01:09:48 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id 164F7380412; Thu, 24 Feb 2022 10:09:46 +0100 (CET) Received: from mail02.x-net.at ([127.0.0.1]) by localhost (mail02.x-net.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ouk16dDb2cP5; Thu, 24 Feb 2022 10:09:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail02.x-net.at (Postfix) with ESMTP id 7DA243803ED; Thu, 24 Feb 2022 10:09:43 +0100 (CET) X-Virus-Scanned: amavisd-new at x-t.at Received: from mail02.x-net.at ([127.0.0.1]) by localhost (mail02.x-net.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id RvmSPcVb9jQJ; Thu, 24 Feb 2022 10:09:43 +0100 (CET) Received: from [127.0.0.1] (unknown [89.144.223.44]) by mail02.x-net.at (Postfix) with ESMTPSA id 404F23801D0; Thu, 24 Feb 2022 10:09:43 +0100 (CET) Date: Thu, 24 Feb 2022 10:09:47 +0100 To: internals@lists.php.net, Go Kudo User-Agent: K-9 Mail for Android In-Reply-To: References: <2c667812-88c8-0b7b-3558-561a1348d0b2@bastelstu.be> <5f496cf9-8754-b009-9cb5-b978222b2249@bastelstu.be> <26a8c3ee-9f0a-793c-10c0-7e642eedf1d0@bastelstu.be> <47cb96f5-4450-0377-dc95-67faac3fef33@bastelstu.be> Message-ID: <27356438-31D1-4FA6-B770-6FD03D3F6AA7@dafert.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [RFC] [Under Discussion] Random Extension 4.0 From: mel@dafert.at (Mel Dafert) On 24 February 2022 09:47:39 CET, Go Kudo wrote: > >Hi > >RFC has been updated=2E Is this up to the required standard? >https://wiki=2Ephp=2Enet/rfc/rng_extension > >I acknowledge that the previous RFC may have been difficult to discuss=2E= If >the problem has been solved, I would like to make another ML-wide >announcement and wait for two weeks from there=2E > >I added PCG64 because according to the RNG experts, there seems to be a >mild conflict between Xorshiro256 and PCG64=2E Also, as mentioned in the = RFC, >Rust and NumPy also implement PCG64=2E > >In order to verify the feasibility of PCG64, we created a PoC in C=2E So = far, >it seems to work fine=2E >https://github=2Ecom/zeriyoshi/pcg64_example > >Regards, >Go Kudo Hello, Two small nits: - The "Backward Incompatible Changes" section is missing the fact that `\Random\Randomizer` will be reserved=2E - In the definition of `Randomizer` in the "Proposal" section, there is a = typo: `function getBytes(int $legnth)` should be `$length` instead=2E To me, this RFC looks very good so far - I don't have a vote however=2E Regards, Mel