Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117110
Message-ID: <270218e0-76f4-4c79-1820-957ce70ca1dd@gmx.de>
Date: Mon, 21 Feb 2022 19:48:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: de-DE
To: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
References: <22242169-a16d-5261-696c-3cf00b00336a@gmail.com>
 <CAFv4g+G2_qmUynYcNNAraXc7UBf1W8viNXda3=WAUwdor+g6PA@mail.gmail.com>
 <93e83a99-8f03-b823-1b4b-a10519d41dd7@gmail.com>
 <CAFv4g+FZQqL_Mbw=obC0AJa6eqZeDaz3+nqtpgZkQOE+ULq_Uw@mail.gmail.com>
 <64095373-f73b-0231-dbd2-3b3271ab0e96@gmail.com>
 <CAFv4g+Heu-Xw_6WhDxVia_WQDuiKWWpf-ccVkmh5HppjCg+P0Q@mail.gmail.com>
 <20220221162953.GA26851@phcomp.co.uk>
 <cf9db66f-430c-880d-f367-85ba7cd82548@gmail.com>
In-Reply-To: <cf9db66f-430c-880d-f367-85ba7cd82548@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Deprecate and Remove utf8_encode and utf8_decode
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 21.02.2022 at 18:35, Rowan Tommins wrote:

> On 21/02/2022 16:29, Alain D D Williams wrote:
>
>> Looking at the description of grapheme_strlen() I note that it can
>> return null.
>> However it does not say why>
> Huh, that feels like a bug to me, since it can also return false, which
> is the more standard way of indicating failure.

This is not the only function which returns null or false for different
kinds of failures.

> The obvious failure case is an input string that's not valid UTF-8, e.g.
> grapheme_strlen("\xFF"). It appears that currently returns null; so I'm
> not actually sure how you'd trigger the false case.

false is returned, if the internal function
grapheme_get_break_iterator() fails.  I'm not sure under which
circumstances that function may fail, but from looking at the code and
the ICU documentation[1], it seems we're relying on functionality which
is deprecated as of ICU 52; it's probably a good idea to adjust the
code, and to possibly bump the ICU version requirements (currently, ICU
>=3D 50.1 is required).

[1]
<https://unicode-org.github.io/icu-docs/apidoc/dev/icu4c/ubrk_8h.html#ad19=
17029dcd00164d18e9d77b73be195>

=2D-
Christoph M. Becker