Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:117096 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 92069 invoked from network); 21 Feb 2022 11:09:31 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 21 Feb 2022 11:09:31 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 0E40F180543 for ; Mon, 21 Feb 2022 04:28:41 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_20, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 21 Feb 2022 04:28:40 -0800 (PST) Received: by mail-vs1-f49.google.com with SMTP id d11so13349728vsm.5 for ; Mon, 21 Feb 2022 04:28:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDA+4T4sstj6E7uJm+Dx1BT+d2SC/epEM1ajDoCcFoA=; b=y9sBHVYEy2JhRHc7IIpMQNZLYj9t3G/uBpI+l2auK4G/9rpa2ITVdBU0pQOaOou25M bZm+c67DzeEyngxVEypXkbhwPucG0PytrLPrSS384Z47AEHhryQAzo7T2wZW6/VLN1am sdvbQvU4A5p4dqLY1LK+GvQgRXY4qsnDPlpSMAeAlPcwF7C1dVRueLaiHQU3zmlDG51W hLpaBLtDK+cXCbszThXEX3OcYoczOFSo7DeaEo4yoPD/UXss5Dk3mzmDYIdq/eWVo5LE snk7hvqCfvRa+JmCabMKJIAvVCTgQGyGO6U2fPEnPPs5W0Qz+r3IflJ7lo8JTDdI3vKI BwNA== X-Gm-Message-State: AOAM533D++jcOJhOkdZB++0F7RxTqcaTDHca5RND6XMyb3I4TklXY+2F wvuIn/7LmXJYvpCBQjraUxw5mmwrHpi3V7c06i8= X-Google-Smtp-Source: ABdhPJw0LDi/orR2XCn7CeNYHmRIhQWOf4vbVQXubay1UvaIYkYBwdKm4/5U7RiNNnVHxR1CqsxuFNzQDRK/bq4Q1Oo= X-Received: by 2002:a67:e3c5:0:b0:31c:a:599c with SMTP id k5-20020a67e3c5000000b0031c000a599cmr5391925vsm.17.1645446519879; Mon, 21 Feb 2022 04:28:39 -0800 (PST) MIME-Version: 1.0 References: <5983302.2649742.1645319015766@email.ionos.com> <6238bf00-011e-35cc-d84b-4082b4f05099@gmail.com> <497325306.1564942.1645357444018@email.ionos.com> <3c6871ca-589d-6812-800c-a3b9ad6bb575@bastelstu.be> <40015164-ac0c-336d-c7d6-c4766d6caff8@gmail.com> <7527ab0b-bed1-6788-a0ff-e75672054be7@bastelstu.be> In-Reply-To: Date: Mon, 21 Feb 2022 12:28:28 +0000 Message-ID: To: Marco Pivetta Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= , Stanislav Malyshev , PHP Internals List Content-Type: multipart/alternative; boundary="000000000000507c3105d8865ff4" Subject: Re: [PHP-DEV] RFC proposal to deprecate crypt() From: bukka@php.net (Jakub Zelenka) --000000000000507c3105d8865ff4 Content-Type: text/plain; charset="UTF-8" > > As mentioned elsewhere in the mail thread, `crypt()` is not designed for > fast hashing, and is in fact slow by design. > What do you mean by slow? Are you aware that password_hash and password_verify for bcrypt are just wrappers around crypt? Just to note that by removing that, we would still need to keep php_crypt in the core and would just get rid of couple of lines for the actual function definitions and arguments so there's absolutely no benefit in terms of maintanance. We have got plenty of functions that are quite low level but offer some additional functionality that can be used by specialised libraries / apps. I think that it's much better to educate users by documentation rather than removing the actual functionality that has got some valid users. We can see that there are some valid use case for using crypt directly and we can also see that it's offered by other languages as well - e.g. Python: https://docs.python.org/3/library/crypt.html . Jakub --000000000000507c3105d8865ff4--