Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117063
Message-ID: <5efecaef-a024-3c61-e12e-ffc342956718@gmail.com>
Date: Fri, 18 Feb 2022 11:23:58 +0000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Content-Language: en-GB
To: internals@lists.php.net
References: <620eda0f.1c69fb81.d2cb1.0846SMTPIN_ADDED_MISSING@mx.google.com>
In-Reply-To: <620eda0f.1c69fb81.d2cb1.0846SMTPIN_ADDED_MISSING@mx.google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Undefined Variable Error Promotion
From: rowan.collins@gmail.com (Rowan Tommins)

On 17/02/2022 23:28, Mark Randall wrote:
> I present:
>
> https://wiki.php.net/rfc/undefined_variable_error_promotion


It would be good to have a "Scope" or "Unaffected Functionality" section 
here, because there are a number of closely related things which were 
also raised from Notice to Warning in 8.0:

- undefined array keys
- undefined object properties
- array access on a non-array
- property access on a non-object

I think it is sensible to discuss those separately, but it would be good 
to make that clear.


Similarly, it would be good to have more discussion of what "accessing" 
means, as the current examples are quite narrow, only showing direct use 
and the ++ operator. Other functionality potentially affected:

- passing the variable to a function, presumably excluding by-reference 
parameters which don't currently warn
- all the combined assignment operators - 
https://www.php.net/manual/en/language.operators.assignment.php
- the array append operator ($a[] = 42;) does NOT currently give an 
undefined variable Warning
- variable variables, e.g. "$b = 'a'; echo $$b;"
- the compact() pseudo-function

There's probably others that I've missed.


Regards,

-- 
Rowan Tommins
[IMSoP]