Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117004
MIME-Version: 1.0
References: <CAFv4g+Efz-V5V1uUedXpusNw6z-on=TT3kdWgC66SptSd8kB4g@mail.gmail.com>
 <CAFv4g+HvM5CPw6DNdsipYmZEb3zjWY2_Use4O+yfxAPBedzFUw@mail.gmail.com>
 <cmu-lmtpd-3262-1644222965-0@darkcity> <7CCE6061-F5BD-4C10-8BD1-F5A2A994D5F6@cschneid.com>
 <CAFPFaMLFe7ZpD-EXg03NFh5CdL3mf9MxXTBstFxASBbo=3FYOA@mail.gmail.com>
 <C484B937-5847-4779-91B7-93A81AB78DFF@cschneid.com> <082301d9-2e69-48ce-a85e-a6e2a57e3f9e@www.fastmail.com>
 <CAFv4g+FmjpY6ub1h08=T2MkFwPOCaGfb-9RupVt9MmV9p+FTLw@mail.gmail.com> <5fcc24de-0861-46fd-95eb-8ca6d326f93e@www.fastmail.com>
In-Reply-To: <5fcc24de-0861-46fd-95eb-8ca6d326f93e@www.fastmail.com>
Date: Mon, 7 Feb 2022 19:20:59 +0000
Message-ID: <CAFv4g+G14rX9=6GGdSWjPT5+jH3c4vuSW31UUe6r3nD0YWqvLw@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c7244f05d772805f"
Subject: Re: [PHP-DEV] Allowing NULL for some internal functions
From: craig@craigfrancis.co.uk (Craig Francis)

--000000000000c7244f05d772805f
Content-Type: text/plain; charset="UTF-8"

On Mon, 7 Feb 2022 at 18:39, Larry Garfield <larry@garfieldtech.com> wrote:

> I'm not suggesting a separate RFC for each.  One RFC with several votes in
> it is fine, IMO.
>
> What I disagree with is changing the definition of strict_types=0 from
> "use the well-documented coercion logic at parameter and return points" to
> "use the well-documented parameter and return points, and also add implicit
> nullability but only for internal functions, sometimes".
>


Thanks Larry, that's fair... I can do that, and update the documentation as
well (will wait a bit to see if anyone else has any feedback).

Now the next problem, if we are going to have "One RFC with several
votes"... I've got 276 functions (336 arguments) which I think should
preserve their old behaviour (as in, there is no reason why a Fatal Error
should happen with a NULL value in PHP 9).

It might be possible to group them, like the 60 functions just related to
encoding values... because voting for them all individually in an RFC would
be a pain (I should know, I was checking each one).

Or should I setup a survey to make it a bit easier to collect yes/no
feedback before the actual RFC vote? I could add a feature to tick or
untick all by default.

Craig


As a side note, there are 99 functions on the "probably not" list (aka
maybe)... and 442 on the "other" list (the edge cases, like `$method` in
`method_exists()`, that would be weird if it was given a NULL).

--000000000000c7244f05d772805f--