Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:117003
User-Agent: Cyrus-JMAP/3.5.0-alpha0-4748-g31a5b5f50e-fm-cal2020-20220204.001-g31a5b5f5
Mime-Version: 1.0
Message-ID: <5fcc24de-0861-46fd-95eb-8ca6d326f93e@www.fastmail.com>
In-Reply-To: 
 <CAFv4g+FmjpY6ub1h08=T2MkFwPOCaGfb-9RupVt9MmV9p+FTLw@mail.gmail.com>
References: 
 <CAFv4g+Efz-V5V1uUedXpusNw6z-on=TT3kdWgC66SptSd8kB4g@mail.gmail.com>
 <CAFv4g+HvM5CPw6DNdsipYmZEb3zjWY2_Use4O+yfxAPBedzFUw@mail.gmail.com>
 <cmu-lmtpd-3262-1644222965-0@darkcity>
 <7CCE6061-F5BD-4C10-8BD1-F5A2A994D5F6@cschneid.com>
 <CAFPFaMLFe7ZpD-EXg03NFh5CdL3mf9MxXTBstFxASBbo=3FYOA@mail.gmail.com>
 <C484B937-5847-4779-91B7-93A81AB78DFF@cschneid.com>
 <082301d9-2e69-48ce-a85e-a6e2a57e3f9e@www.fastmail.com>
 <CAFv4g+FmjpY6ub1h08=T2MkFwPOCaGfb-9RupVt9MmV9p+FTLw@mail.gmail.com>
Date: Mon, 07 Feb 2022 12:38:44 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] Allowing NULL for some internal functions
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Feb 7, 2022, at 10:39 AM, Craig Francis wrote:
> On Mon, 7 Feb 2022 at 15:15, Larry Garfield <larry@garfieldtech.com> wrote:

> If there's an argument to be made to rewiden a type to include null, make
>> that case and have that debate on a function by function basis.
>
>
> I'm fine with that, but I worry people are underestimating the size of the
> problem (having a debate on each one would take a long time).
>
> I've put together my proposed list, it took a few days, and a lot of
> thought:
>
> https://github.com/craigfrancis/php-allow-null-rfc/blob/main/functions-change.md

I'm not suggesting a separate RFC for each.  One RFC with several votes in it is fine, IMO.

What I disagree with is changing the definition of strict_types=0 from "use the well-documented coercion logic at parameter and return points" to "use the well-documented parameter and return points, and also add implicit nullability but only for internal functions, sometimes".

If it makes sense for strlen() to be nullable, then it makes sense for strlen() to be nullable.  One or the other, not both based on a flag.

> I've asked for suggestions and pull requests a few times, and the best I've
> got is `$path`/`$domain` for `setcookie()` (I disagree because `NULL` is
> often used for those arguments, so that `$secure` and `$httponly` can be
> set to true).

Such is the RFC process...

--Larry Garfield