Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116961
Return-Path: <levi.morrison@datadoghq.com>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 33172 invoked from network); 1 Feb 2022 02:26:55 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 1 Feb 2022 02:26:55 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 712921804DF
	for <internals@lists.php.net>; Mon, 31 Jan 2022 19:40:59 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,T_SPF_TEMPERROR autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-ASN: AS15169 209.85.128.0/17
X-Spam-Virus: No
X-Envelope-From: <levi.morrison@datadoghq.com>
Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Mon, 31 Jan 2022 19:40:59 -0800 (PST)
Received: by mail-yb1-f177.google.com with SMTP id p5so46766624ybd.13
        for <internals@lists.php.net>; Mon, 31 Jan 2022 19:40:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=datadoghq.com; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=uFFu0VqaYaBiC7CHn6UTEHuX7B5bIsz26XjqWAptW9w=;
        b=UlABgvuGCOrRUWHr7XyVwx/2ssA3ryWAbT3+Zrscd6KJzsR77EUCi65xmtTxmBzcHN
         BmdUOk7jaLz7oEVA2A/FgCDaNHkMYAm3VZC9fisRUVY4/OoXsejh5cdopRBKOnKa55uU
         Z1Qo+4qoATtCNRkJD7TxmK+qJuKwlKgk0jGxc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=uFFu0VqaYaBiC7CHn6UTEHuX7B5bIsz26XjqWAptW9w=;
        b=mj9BTuwgBEjU0mDOxxbJN9aT0VruMAFajgWyuKUzsYpqpzqYHLVJUtd4F8ZBCwkZcq
         rdR5UtZGzQU1KLAHeg0DM+H7O9GmBUuE/4ZJPFV0qu39jCVr+zQHy2YBUFeY0bSY/1Ni
         tmO4HQYiNQK8a+32YCP0M1bKEbQ4Zg3hZrurVDbByumwexiaPFspKAE7DoY7dRy/d8g/
         5ZmcajTXKekOSoQmfhfpo3AShElLlNIfg5ANSRC/Pj3/KGsKro2w+dNMN3vFkMrygOer
         nJesKPrthyccLZqKDQNQ2R0w70S7WObiJ77j7rNfz9QyPty7ajERa5/WaG32VCz8DhKR
         h8lA==
X-Gm-Message-State: AOAM533JiYBD7tn+DdNMBPu5ZPJJ6mUK09Eq/iYehipsaGl7LOemjQCn
	eBTGeNSVTkI7ZA9qxG5OzPDEoNpv9bPOyTQyg7xAIA==
X-Google-Smtp-Source: ABdhPJxrmpV6kW1uAxLKXN0n/s6r/wusRVuD6wORZFNOVQTgCFHVIBdlbngj6MU8Qsvrh0NLT2lo7LWeUFvJKowF8lk=
X-Received: by 2002:a25:6fc4:: with SMTP id k187mr33302570ybc.709.1643686858301;
 Mon, 31 Jan 2022 19:40:58 -0800 (PST)
MIME-Version: 1.0
References: <DM6PR07MB66185E23B803C5E5BF858B30F9DF9@DM6PR07MB6618.namprd07.prod.outlook.com>
 <A59125BE-AF91-44D1-9B47-82046B51EE8F@newclarity.net> <CAEZPtU7+hgcHwRfaa7-CR9SVv2=HfH46kDVu0pDYm5M=WeFPVg@mail.gmail.com>
 <67BFE5C6-3C3F-4309-97A2-14CA0D8C3B3B@newclarity.net> <CAEZPtU62gfKb-xODqm_yk-BE_ycLshuD2_ps733_ReFgksLqaQ@mail.gmail.com>
 <7BEE0406-3CAE-4E83-A196-F9F608BE8D17@newclarity.net> <CAAKU0uk6Wvd5aPQ4qzJTQiHpuLCM999Wsm7qrjWMonF7q+SuDw@mail.gmail.com>
 <CAF+90c84NGyL2Kq1k0d=V_G0K96wCvdfqsvtrTYkneVvpHSFmw@mail.gmail.com>
 <DM5PR17MB1481CB947F6D5412FC474D80F9AE9@DM5PR17MB1481.namprd17.prod.outlook.com>
 <CAF+90c-kdmoDz-TzdaPGaHq_5x7qgp=mi4AnS13UCQme2c2OMw@mail.gmail.com> <DM6PR14MB41552CC4E70356D9BA73A40BF9269@DM6PR14MB4155.namprd14.prod.outlook.com>
In-Reply-To: <DM6PR14MB41552CC4E70356D9BA73A40BF9269@DM6PR14MB4155.namprd14.prod.outlook.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Mon, 31 Jan 2022 20:40:47 -0700
Message-ID: <CAAKU0u=XQ9PYMqcU2M1gbsxfBMb=ZYSP0M=2vFHEKLrOmxQ5mA@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Adding `final class Deque` to PHP
From: internals@lists.php.net ("Levi Morrison via internals")

I think this RFC is in much better shape now.

The last thing I'll personally push for is dropping `get` and `set`.
I'm not sure about those names, and the functionality is already
provided by `offsetGet` and `offsetSet`, albeit through `mixed`
instead of `int`, but I think this sort of cleanup should be done en
masse at some point, rather than having this one type doing something
different from the others.