Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:116869
MIME-Version: 1.0
References: <ded42b3e-3149-1192-0f86-07715fcb7a3e@woltlab.com>
 <CAEZPtU7OUyymnN1DUhwM5PdTGPZnAgqCy84u6tjDRGBekpidNg@mail.gmail.com> <d6caa3bf-85b5-f14b-7efa-5bda54f2e698@woltlab.com>
In-Reply-To: <d6caa3bf-85b5-f14b-7efa-5bda54f2e698@woltlab.com>
Date: Tue, 11 Jan 2022 19:41:43 +0700
Message-ID: <CAEZPtU6uwVHuRBNjMSzPdrC9ags+_1yCeTE9coXL0AjsvxyCxA@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus=2C_WoltLab_GmbH?= <duesterhus@woltlab.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Redacting parameters in back traces
From: pierre.php@gmail.com (Pierre Joye)

Hi Tim,

On Tue, Jan 11, 2022 at 4:40 PM Tim D=C3=BCsterhus, WoltLab GmbH
<duesterhus@woltlab.com> wrote:
>
> Hi Pierre
>
> On 1/11/22 4:48 AM, Pierre Joye wrote:
> > Also sensitive data goes way beyond arguments, GDPR brings a lot of
> > issues here too. Userland packages like monolog provide filters or
> > custom output, I think that is where it should be handled.
>
> I believe that the author of a function is in the best position to
> decide whether a specific argument generally holds sensitive data or
> not. This avoids every exception handler / logger / =E2=80=A6 having to c=
heck
> what function parameters hold sensitive data and scrubbing them,
> possibly missing some.

You are fully correct here.

My thoughts differ as I think there are better tools to handle this
than PHP itself, as well as all other cases where sensitive data may
be exposed (a lot more than backtrace, which is handled already using
the ini setting).
Things like query errors, etc. There is no way we can handle them all
and this is really the developer responsibility to handle this data in
a safe manner. We do our best at the engine level for critical data
from an engine point of view. Application level critical data are the
developers responsibility (config, code, etc.).

Best,
--=20
Pierre

@pierrejoye | http://www.libgd.org